unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 64535@debbugs.gnu.org
Subject: bug#64535: 30.0.50; Spurious newlines in `prin1` output
Date: Sun, 09 Jul 2023 08:09:49 +0300	[thread overview]
Message-ID: <83v8etbrhe.fsf@gnu.org> (raw)
In-Reply-To: <jwvfs5y43f2.fsf@iro.umontreal.ca> (bug-gnu-emacs@gnu.org)

> Date: Sat, 08 Jul 2023 15:19:13 -0400
> From:  Stefan Monnier via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> `prin1` never inserts newlines unless they're within strings (and that
> can be controlled with `print-escape-newlines`), right?  Right?
> 
> Nope: it does insert newlines inside char-table when reaching the 3rd
> level of subtables.  This was done to work around the long lines problem
> in redisplay (bug#2866), but it's far from the only case where `prin1`
> can emit a long line, and we've significantly improved our handling of
> long lines.
> 
> Can we get rid of this quirk now, please?

I'm okay with getting rid of it, with two conditions:

  . removing newline insertion in the scenario of bug#2866 leaves
    Emacs sufficiently performant, even in the unoptimized build, and
  . we will still insert a newline if long-line-threshold is nil

IOW, I don't want us to bring back regressions as result of this
cleanup.

Thanks.





  reply	other threads:[~2023-07-09  5:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-08 19:19 bug#64535: 30.0.50; Spurious newlines in `prin1` output Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09  5:09 ` Eli Zaretskii [this message]
2023-07-13 23:11   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 13:38     ` Eli Zaretskii
2023-07-14 14:46       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15  7:29         ` Eli Zaretskii
2023-07-15 15:20           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-10 16:00         ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v8etbrhe.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64535@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).