From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Fri, 21 Jul 2023 15:46:26 +0300 Message-ID: <83v8edzb31.fsf@gnu.org> References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <837cqu35lw.fsf@gnu.org> <87o7k6pmk3.fsf@localhost> <834jly351p.fsf@gnu.org> <87lefapkdx.fsf@localhost> <831qh230h5.fsf@gnu.org> <87wmyu8mi0.fsf@localhost> <83wmyu1l1k.fsf@gnu.org> <87fs5hemi1.fsf@gmx.de> <83edl11qzn.fsf@gnu.org> <874jlxebz5.fsf@gmx.de> <87lef9mqio.fsf@localhost> <87edl1scbw.fsf@gmx.de> <87fs5hmp6i.fsf@localhost> <87cz0lmoxy.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7086"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, michael.albinus@gmx.de, 64735@debbugs.gnu.org, sbaugh@janestreet.com To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 14:47:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMpXQ-0001dB-OA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 14:47:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMpXD-0003oJ-QD; Fri, 21 Jul 2023 08:47:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMpXC-0003nq-98 for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 08:47:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMpXC-0006BN-1M for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 08:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMpXB-0008K1-U4 for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 08:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.168994357731932 (code B ref 64735); Fri, 21 Jul 2023 12:47:01 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 21 Jul 2023 12:46:17 +0000 Original-Received: from localhost ([127.0.0.1]:60851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMpWT-0008Iy-Bd for submit@debbugs.gnu.org; Fri, 21 Jul 2023 08:46:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMpWR-0008Io-OP for 64735@debbugs.gnu.org; Fri, 21 Jul 2023 08:46:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMpWI-0005pr-KM; Fri, 21 Jul 2023 08:46:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pA2D+kQCW2pjhu8iqOuIoNirmB1G0z71J5unhP3zcBw=; b=rUVHr4cIgeSQ VDx1gBiDvX5dR8hhZQwW8gVdrtAhDpNzIcHpMM1u9gpLUHPFo+tagGM0/8A/SicaO5AS7hvgVmEuM 45jfL6u7ezqo68KPFZS7qK3yW81DspJvXE/XDVCe9YYUaCEqd+WFWQZmKdq3pjns4qgAWsz4LMmhT Qet7uLX+ZE0Fjm69+7mffRAO8cKNx0JbuV5bV0k10vyc19Bl3hIENiQaVhFSqr13wNLDxom8mGGO2 QtZpvzfddUUF/qmHYuuGp4ywR9dRuywmdMZDHyjl3xxyEKVBOHQfrLCbNUM1ew17y2UYaYtaSPH6K vfMHiJObUosgRxSLXxBjJw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMpW1-0006Ea-R3; Fri, 21 Jul 2023 08:46:05 -0400 In-Reply-To: <87cz0lmoxy.fsf@localhost> (message from Ihor Radchenko on Fri, 21 Jul 2023 12:25:29 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265694 Archived-At: > From: Ihor Radchenko > Cc: dmitry@gutov.dev, Eli Zaretskii , 64735@debbugs.gnu.org, > sbaugh@janestreet.com > Date: Fri, 21 Jul 2023 12:25:29 +0000 > > Ihor Radchenko writes: > > > The question is: what is more costly > > (a) matching complex regexp && call function or > > (b) call function (lambda (fn) (when (and foo (match-string- ... fn)) ...)) > > (benchmark-run-compiled 10000000 (string-match-p (caar file-name-handler-alist) "/path/to/very/deep/file")) > ;; => (1.495432981 0 0.0) > (benchmark-run-compiled 10000000 (funcall (lambda (fn) (and nil (string-match-p (caar file-name-handler-alist) fn))) "/path/to/very/deep/file")) > ;; => (0.42053276500000003 0 0.0) > > Looks like even funcall overheads are not as bad as invoking regexp search. But "nil" is not a faithful emulation of the real test which will have to be put there, is it?