From: Eli Zaretskii <eliz@gnu.org>
To: sbaugh@janestreet.com
Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com
Subject: bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename
Date: Thu, 03 Aug 2023 11:00:43 +0300 [thread overview]
Message-ID: <83v8dwy2qc.fsf@gnu.org> (raw)
In-Reply-To: <83cz0eog5a.fsf@gnu.org> (message from Eli Zaretskii on Wed, 26 Jul 2023 18:18:25 +0300)
Ping! Can this test failure be fixed, please?
> Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com
> Date: Wed, 26 Jul 2023 18:18:25 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Spencer Baugh <sbaugh@janestreet.com>
> > Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com
> > Date: Mon, 24 Jul 2023 15:18:23 -0400
> >
> > > OK, how about this?
> >
> > Oops, that one didn't include the updated
> > project-uniquify-dirname-transform docstring. The right patch now:
>
> Thanks, installed, with some minor changes as followup.
>
> The new test uniquify-home fails for me on MS-Windows:
>
> Test uniquify-home backtrace:
> signal(ert-test-failed (((should (equal (mapcar #'buffer-name bufs)
> ert-fail(((should (equal (mapcar #'buffer-name bufs) '("~<test>" "~<
> (if (unwind-protect (setq value-27 (apply fn-25 args-26)) (setq form
> (let (form-description-29) (if (unwind-protect (setq value-27 (apply
> (let ((value-27 'ert-form-evaluation-aborted-28)) (let (form-descrip
> (let* ((fn-25 #'equal) (args-26 (condition-case err (let ((signal-ho
> (save-excursion (setq bufs (cons (find-file-noselect "~") bufs)) (se
> (let (bufs) (save-excursion (setq bufs (cons (find-file-noselect "~"
> (closure (t) nil (let (bufs) (save-excursion (setq bufs (cons (find-
> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> ert-run-test(#s(ert-test :name uniquify-home :documentation "uniquif
> ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
> ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
> ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
> ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
> eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
> command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/uniquify-tests.el" "
> command-line()
> normal-top-level()
> Test uniquify-home condition:
> (ert-test-failed
> ((should (equal (mapcar ... bufs) '("~<test>" "~<>"))) :form
> (equal ("~" "nonexistent") ("~<test>" "~<>")) :value nil
> :explanation
> (list-elt 0
> (arrays-of-different-length 1 7 "~" "~<test>"
> first-mismatch-at 1))))
>
> The idea of the test is not clear to me, so I cannot tell what could
> be the reasons. Feel free to ask me to test changes or ask questions
> about what happens on this Windows system while running the test.
>
>
>
>
next prev parent reply other threads:[~2023-08-03 8:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 17:37 bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename Spencer Baugh
2023-04-02 17:57 ` Eli Zaretskii
2023-04-02 21:59 ` Drew Adams
2023-04-02 18:25 ` Juri Linkov
2023-04-14 16:08 ` Spencer Baugh
2023-07-13 22:51 ` sbaugh
2023-07-14 6:29 ` Eli Zaretskii
2023-07-14 11:28 ` sbaugh
2023-07-14 12:01 ` Eli Zaretskii
2023-07-14 12:20 ` Spencer Baugh
2023-07-14 12:29 ` Eli Zaretskii
2023-07-14 12:46 ` Spencer Baugh
2023-07-14 13:51 ` Eli Zaretskii
2023-07-14 14:14 ` Spencer Baugh
2023-07-14 19:10 ` Eli Zaretskii
2023-07-14 19:15 ` sbaugh
2023-07-15 5:42 ` Eli Zaretskii
2023-07-15 6:20 ` Eli Zaretskii
2023-07-18 0:19 ` Dmitry Gutov
2023-07-18 1:37 ` Dmitry Gutov
2023-07-18 16:03 ` Spencer Baugh
2023-07-19 2:47 ` Dmitry Gutov
2023-07-19 6:56 ` Juri Linkov
2023-07-18 17:51 ` Juri Linkov
2023-07-19 2:24 ` Dmitry Gutov
2023-07-14 16:31 ` Juri Linkov
2023-07-18 0:34 ` Dmitry Gutov
2023-07-18 11:07 ` Eli Zaretskii
2023-07-19 2:22 ` Dmitry Gutov
2023-07-19 12:14 ` Eli Zaretskii
2023-07-19 12:31 ` Spencer Baugh
2023-07-19 13:25 ` Eli Zaretskii
2023-07-21 13:34 ` Spencer Baugh
2023-07-21 14:37 ` Eli Zaretskii
2023-07-22 18:00 ` Spencer Baugh
2023-07-24 19:18 ` Spencer Baugh
2023-07-26 15:18 ` Eli Zaretskii
2023-08-03 8:00 ` Eli Zaretskii [this message]
2023-08-03 11:54 ` Spencer Baugh
2023-08-03 14:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8dwy2qc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62621@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).