unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "J.P." <jp@neverwas.me>
Cc: emacs-erc@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
	23675@debbugs.gnu.org, rsw@gnu.org
Subject: bug#23675: 30.0.50: make count-lines optionally ignore invisible lines
Date: Sat, 05 Aug 2023 09:32:26 +0300	[thread overview]
Message-ID: <83v8dut2x1.fsf__32791.6189607762$1691217203$gmane$org@gnu.org> (raw)
In-Reply-To: <87ttteuy0g.fsf@neverwas.me> (jp@neverwas.me)

> Cc: emacs-erc@gnu.org, rsw@gnu.org
> From: "J.P." <jp@neverwas.me>
> Date: Fri, 04 Aug 2023 17:35:27 -0700
> 
> Perhaps I'm not understanding how the `ignore-invisible-lines' parameter
> for `count-lines' is supposed to work, but it doesn't seem to make the
> function consider `invisible' text properties that have lists as values.
> I bring this up because ERC will likely be needing a line-counting
> function that's list-aware, at least in the manner shown in the attached
> tests. The change to `count-lines' accompanying these tests was merely
> lifted from `forward-visible-line' to make them pass, but it's quite
> possibly flawed and/or incomplete. If a proper solution ever emerges to
> address this, hopefully it'll come at the hands of someone better
> informed than I in the ways of Emacs invisibility. In the meantime
> (2023), ERC will likely be doing its own subpar rendition unless someone
> takes up the challenge for 30.1 (and Compat agrees to adopt it). Thanks.

This is OK for master, but please don't use cl-incf in simple.el, as
there's no real need to do so there.

Stefan, any comments?





  parent reply	other threads:[~2023-08-05  6:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 14:23 bug#23675: Feature request: Emacs 25.0.94: count-lines should offer a way to ignore invisible lines, e.g. outline mode Robert Weiner
2016-06-04  8:58 ` Eli Zaretskii
2016-06-06 23:35 ` Robert Weiner
     [not found] ` <CA+OMD9houRLimgDdDkC0TEg7Rk_c9qmQ9+7ebURoxy6c=vZvVw@mail.gmail.com>
2016-06-07 15:58   ` Eli Zaretskii
2016-06-07 22:17     ` Robert Weiner
2019-06-25 15:33       ` Stefan Monnier
2019-06-25 13:30   ` Lars Ingebrigtsen
     [not found]   ` <m35zotaj23.fsf@gnus.org>
2019-06-25 15:26     ` Stefan Monnier
2019-06-25 15:29       ` Lars Ingebrigtsen
2020-08-11 14:53   ` Lars Ingebrigtsen
2023-08-05  0:35 ` bug#23675: 30.0.50: make count-lines optionally ignore invisible lines J.P.
     [not found] ` <87ttteuy0g.fsf@neverwas.me>
2023-08-05  6:32   ` Eli Zaretskii [this message]
     [not found]   ` <83v8dut2x1.fsf@gnu.org>
2023-08-06 13:03     ` J.P.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='83v8dut2x1.fsf__32791.6189607762$1691217203$gmane$org@gnu.org' \
    --to=eliz@gnu.org \
    --cc=23675@debbugs.gnu.org \
    --cc=emacs-erc@gnu.org \
    --cc=jp@neverwas.me \
    --cc=monnier@iro.umontreal.ca \
    --cc=rsw@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).