From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' Date: Sun, 20 Aug 2023 11:50:04 +0300 Message-ID: <83v8daw11f.fsf@gnu.org> References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> <83sf8g523j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65346-done@debbugs.gnu.org To: Lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 10:50:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXe8W-0001yh-9n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 10:50:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXe8J-0005Cm-BF; Sun, 20 Aug 2023 04:50:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXe8H-0005Bn-9T for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 04:50:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXe8G-0007TN-W0 for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 04:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXe8I-0004kL-Dd for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 04:50:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65346 X-GNU-PR-Package: emacs Mail-Followup-To: 65346@debbugs.gnu.org, eliz@gnu.org, sunlin7@yahoo.com Original-Received: via spool by 65346-done@debbugs.gnu.org id=D65346.169252139918226 (code D ref 65346); Sun, 20 Aug 2023 08:50:02 +0000 Original-Received: (at 65346-done) by debbugs.gnu.org; 20 Aug 2023 08:49:59 +0000 Original-Received: from localhost ([127.0.0.1]:53082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXe8E-0004ju-SD for submit@debbugs.gnu.org; Sun, 20 Aug 2023 04:49:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXe8C-0004je-Nn for 65346-done@debbugs.gnu.org; Sun, 20 Aug 2023 04:49:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXe85-0007S4-TX; Sun, 20 Aug 2023 04:49:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FIfjAS6R3ttl8U5X93AGO+4/9E54+00X4VhYzL4MUbo=; b=A2Bmdg0Kzm9ec5Hh3wCv 18OIYZ9CaAmsAB1kGn38TG4J5caFc4cTmdqbFVsvSATsk8le6y/rLAkoiwRyywvNY6fQTheeENNP2 L8nu1eUxPAF8AumSIykjoHbTegHBHvTHKEJNkRRcN9Sks8DD28+TFONlhgLoALZzFKvf0CjIxPRFA qfiQNlH6cSARP3gjsGMODT5zjrekhuF7y0CWvytmtZIDmlBtpC6CeMWdrRJQAkrIgnIKdYGRPiws4 /HbdKLSeGUMtxBjiRQh3VZbk/2gL4yzxbLUPaFUShRutA8Rk9lbogge+cMqSKmf2OENT2HT4cfYXh pDbmD09FnPnWbQ==; In-Reply-To: (message from Lin Sun on Fri, 18 Aug 2023 19:03:08 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267970 Archived-At: > From: Lin Sun > Date: Fri, 18 Aug 2023 19:03:08 +0000 > Cc: 65346@debbugs.gnu.org > > On Fri, Aug 18, 2023 at 5:52 AM Eli Zaretskii wrote: > > This changes the API of a public function in incompatible ways, which > > we try very hard not to do. Instead, the signature or > > eww-open-in-new-buffer should be like this: > > > > (defun eww-open-in-new-buffer (&optional no-select) > > > > and the new NO-SELECT argument should be set non-nil by C-u. > > > > > + (user-error "No avaliable link"))) > > > > This also changes the text of the error message in this case. Was > > that really necessary? The original text was more accurate, I think. > > > > Also, this new feature needs a NEWS entry and a suitable addition to > > the EWW manual. > > The attached patch included changes for the function, error message, > NEWS and EWW manual. > Please help review it. Thanks, installed on master, and closing the bug. Please in the future include a more detailed log of the changes in the commit log message, and please follow our conventions for that as described in CONTRIBUTE. I did it for you this time, but it required quite a lot of manual work.