From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Date: Mon, 21 Aug 2023 14:05:07 +0300 Message-ID: <83v8d8veos.fsf@gnu.org> References: <6e426233-31f9-b93e-302b-0d789a7cea44@gmail.com> <83pm3ivufg.fsf@gnu.org> <5a90736e-2a04-3f6c-9b0c-ef60e80426a0@gmail.com> <83o7j1x5kl.fsf@gnu.org> <88b9b3db-2414-b47d-6c8a-31ecce0523af@gmail.com> <83msylx2je.fsf@gnu.org> <874jksj04c.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27343"; mail-complaints-to="usenet@ciao.gmane.io" Cc: maurooaranda@gmail.com, 65401@debbugs.gnu.org To: Philip Kaludercic , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 21 13:05:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qY2il-0006rs-90 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Aug 2023 13:05:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY2iT-0005ns-Nc; Mon, 21 Aug 2023 07:05:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY2iS-0005nb-6k for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 07:05:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qY2iR-00088q-Uv for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 07:04:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qY2iT-0001TM-NG for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 07:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 11:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65401 X-GNU-PR-Package: emacs Original-Received: via spool by 65401-submit@debbugs.gnu.org id=B65401.16926159005649 (code B ref 65401); Mon, 21 Aug 2023 11:05:01 +0000 Original-Received: (at 65401) by debbugs.gnu.org; 21 Aug 2023 11:05:00 +0000 Original-Received: from localhost ([127.0.0.1]:55683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY2iR-0001T3-L5 for submit@debbugs.gnu.org; Mon, 21 Aug 2023 07:05:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY2iQ-0001Sn-2U for 65401@debbugs.gnu.org; Mon, 21 Aug 2023 07:04:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY2iI-00086a-DJ; Mon, 21 Aug 2023 07:04:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IsYLQnHIZbLAdUFaA/FhA/9CNJPQfxn3KlKqyf/eQvE=; b=TLYvNb+bMATaad0toRuM Byjw03AhfgMTYu4mqjpydCUD3EZfllOMxf1sajz4cqMunmsewG/kYjRSKNzj4AgIc28bvFMjPKQOM LchyA08WZ1jTQsU5BgYsvoUiB3dV6wVVDA57v+eosHFezs4yeQAnNIGt1C5UH75KvokhBNNAzmxlw 47NZdEhXmwYtgR2VtPS3lY/vy2lS9vd/lQuaEFZfQXI/4xWXfgXHvFNjk7hooxogMVVZ+dUQnPiJ4 g64xvEaYlYjFRLiHDnTc9G1vy0ypVtQgQoD+d8fV9yUSEA6dDhdtytAnsC36h5JZ9T5zZD/BdIDPc 0dujn2/j64gAEw==; In-Reply-To: <874jksj04c.fsf@posteo.net> (message from Philip Kaludercic on Mon, 21 Aug 2023 08:00:35 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268078 Archived-At: > From: Philip Kaludercic > Cc: Eli Zaretskii , 65401@debbugs.gnu.org > Date: Mon, 21 Aug 2023 08:00:35 +0000 > > Mauro Aranda writes: > > > Eli Zaretskii writes: > > > >>> Date: Sun, 20 Aug 2023 09:35:17 -0300 > >>> Cc: 65401@debbugs.gnu.org > >>> From: Mauro Aranda > >>> > >>> Eli Zaretskii writes: > >>> > >>>  > If the directory doesn't have to exist, then what is the difference > >>>  > between :directory and :string? > >>> > >>> Completion when editing via Customize is the only one it comes to my > >>> mind right now (useful when the user wants to edit it to some directory > >>> it already exists). > >> > >> Then I don't see why would anyone object to the change you propose. > >> It has no downsides, AFAICT. > >> > >> Thanks. > > > > OK, thank you.  I attach the patch. > > > > From c34dea06956f2a3d098badf9cea089bee0f7b61b Mon Sep 17 00:00:00 2001 > > From: Mauro Aranda > > Date: Sun, 20 Aug 2023 10:39:49 -0300 > > Subject: [PATCH] Improve type of custom-theme-directory (Bug#65401) > > > > * lisp/custom.el (custom-theme-directory): Make it of type directory. > > --- > > lisp/custom.el | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lisp/custom.el b/lisp/custom.el > > index 083349e3591..5b244464d0b 100644 > > --- a/lisp/custom.el > > +++ b/lisp/custom.el > > @@ -1208,9 +1208,9 @@ custom-theme-directory > > directory. By default, Emacs searches for custom themes in this > > directory first---see `custom-theme-load-path'." > > :initialize #'custom-initialize-delay > > - :type 'string > > + :type 'directory > > :group 'customize > > - :version "22.1") > > + :version "30.1") > > Does the version tag have to be bumped, for a metadata change this like? Probably not. AFAIK, this is only used for showing "new and changed" options when users upgrade, and this change will be invisible at user level. Stefan, am I missing something?