From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65805: 30.0.50; quoted-insert doesn't work in zap-to-char Date: Mon, 11 Sep 2023 14:44:12 +0300 Message-ID: <83v8chq6ib.fsf@gnu.org> References: <834jk6yqbh.fsf@gnu.org> <83v8cisdik.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1786"; mail-complaints-to="usenet@ciao.gmane.io" Cc: fgunbin@fastmail.fm, 65805@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 11 13:45:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qffLs-0000GK-K5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Sep 2023 13:45:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qffLi-0007Rc-K9; Mon, 11 Sep 2023 07:45:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qffLd-0007D7-Tc for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 07:44:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qffLd-00027W-JP for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 07:44:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qffLh-00028T-Iu for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 07:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2023 11:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65805 X-GNU-PR-Package: emacs Original-Received: via spool by 65805-submit@debbugs.gnu.org id=B65805.16944326858174 (code B ref 65805); Mon, 11 Sep 2023 11:45:01 +0000 Original-Received: (at 65805) by debbugs.gnu.org; 11 Sep 2023 11:44:45 +0000 Original-Received: from localhost ([127.0.0.1]:52267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qffLR-00027m-8v for submit@debbugs.gnu.org; Mon, 11 Sep 2023 07:44:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qffLO-00027X-Lz for 65805@debbugs.gnu.org; Mon, 11 Sep 2023 07:44:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qffLF-00024B-82; Mon, 11 Sep 2023 07:44:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XUz2k7TbNBy8FqAuyhaJVxMpeFD2rLWR6ZRNrjGMH2s=; b=l1evzVAsSPHN 40qazREkkOE18i37YnkOrAP8vik7vO6Zt+nvN17SMEuZN77s3PI3NI9VWAFUWizIOfEaOhl8awh2S hf8DU4eLhzuDC6bJ6OoO8k16TpzYjWnmmm76bQlu82Ba240z94aqJHDd3Z1ISKobKgaN1JGLIwSS0 AUjCj2832wlNZRYOKESm6OsAkJbb5Zgk6CA9/E8NfTtx5CxgYt2w52qlZbMFeJpFZofguM/7kQJcB Hkk861vpk2VBBOwKwggvIA9ybeUkSHFC5ZqHPt10tCB4afK/Y13NE3jhnD/UG+g/kKAEmdO2ELWIV ubiDwRGxWOXnAzHoHP4GjQ==; In-Reply-To: (message from Stefan Monnier on Sun, 10 Sep 2023 19:14:34 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270035 Archived-At: > From: Stefan Monnier > Cc: fgunbin@fastmail.fm, 65805@debbugs.gnu.org > Date: Sun, 10 Sep 2023 19:14:34 -0400 > > >> > That's because we switched to using read-from-minibuffer (via > >> > read-char-from-minibuffer) instead of using read-char, for the dubious > >> > benefit of being able to use history in this command, see bug#10477. > >> > And read-from-minibuffer interprets some characters specially. > >> > Stefan, is there a way to have this cake and eat it, too? > >> How 'bout the patch below? > > Had a missing `nil`. > > > Is this appropriate for emacs-29? > > It looks fairly safe, but is it a regression in Emacs-29 or was it > already there in Emacs-28? It was already in Emacs 28. > If it's not a regression in Emacs-29, I'd keep it in `master`. OK, then please install on master and close this bug when you do. > >> AFAICT it would also make it unnecessary to use > >> `read-char-from-minibuffer-insert-char`. > > Not sure I understand what are you proposing here about that function. > > `read-char-from-minibuffer-insert-char` is a function which just inserts > a char and then exits the minibuffer. With my patch, > `self-insert-command` should work as well for that. I'm okay with making such a change, but we'd probably need a compatibility shim if we do that? So maybe it isn't worth the hassle, just make read-char-from-minibuffer-insert-char obsolete?