From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Date: Fri, 06 Oct 2023 16:46:47 +0300 Message-ID: <83v8bj2794.fsf@gnu.org> References: <87r0mni6m1.fsf@breatheoutbreathe.in> <87bkdq3nw6.fsf@web.de> <875y3yx221.fsf@breatheoutbreathe.in> <87pm260wh9.fsf@web.de> <87v8bx48ww.fsf@breatheoutbreathe.in> <87msx8sbpv.fsf@web.de> <87bkdoh1gy.fsf@breatheoutbreathe.in> <87h6ngs85e.fsf@web.de> <87ttr7nzyj.fsf@breatheoutbreathe.in> <83pm1u6f8l.fsf@gnu.org> <83fs2o2wb0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15284"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, philipk@posteo.net, 66187@debbugs.gnu.org, joseph@breatheoutbreathe.in To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 06 15:48:00 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qolBP-0003gW-8w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Oct 2023 15:47:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qolBE-0004s5-Ut; Fri, 06 Oct 2023 09:47:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qolBA-0004ru-UU for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 09:47:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qolB9-0001sB-5L for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 09:47:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qolBR-0007DL-LZ for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 09:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Oct 2023 13:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66187 X-GNU-PR-Package: emacs Original-Received: via spool by 66187-submit@debbugs.gnu.org id=B66187.169660003127624 (code B ref 66187); Fri, 06 Oct 2023 13:48:01 +0000 Original-Received: (at 66187) by debbugs.gnu.org; 6 Oct 2023 13:47:11 +0000 Original-Received: from localhost ([127.0.0.1]:49465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qolAZ-0007BO-H7 for submit@debbugs.gnu.org; Fri, 06 Oct 2023 09:47:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qolAV-0007As-5v for 66187@debbugs.gnu.org; Fri, 06 Oct 2023 09:47:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qolA5-0001iA-H6; Fri, 06 Oct 2023 09:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zWyaGfaqBUUdReaoAwkEgdRAsW+jeDYWqcHGeg7sRFw=; b=HWFFj6YJsJzr 0flgEr8pF4YLm/xtBB0Bbjo9pYvalP0m77l2jupW7WvMkxFK44B8DZq8fnjylyYtYWtoIdUv0ynEU znF6sXR7rWK9x1R0JlvYx6i5mh8TBvcwnnqOiwhSnC7frquWScLAUDmVi8n0sWfWTBMU6RV266RTL c372oLOECJ7pEDJwx/w9nzJ2+7MaqGP7Kng759lxRV8hdjkeWd4ZOgI6Da1oSGF7XwLsMi34wh8p6 oxctv2QsL1QAnHcYL5yNAFHiteQ4w0QRfXJ/YgcVMn5wwjD3dQHDFlsCvlBFwqvekJfwn7WZJQJPL WgIN2fPAqYP7qPiMrPP1VA==; In-Reply-To: (message from Stefan Monnier on Fri, 06 Oct 2023 09:01:23 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271949 Archived-At: > From: Stefan Monnier > Cc: joseph@breatheoutbreathe.in, michael_heerdegen@web.de, > philipk@posteo.net, 66187@debbugs.gnu.org > Date: Fri, 06 Oct 2023 09:01:23 -0400 > > >> >> For example, given: > >> >> > >> >> (completing-read "Prompt: " '("a" "b") nil > >> >> (lambda (input) > >> >> (string= "a" input))) > >> >> > >> >> I expected that the prompt would refuse to complete "b". I was wrong. > >> >> > >> >> Since completing-read is such a fundamental part of Emacs, I doubt it > >> >> will be possible to change this behavior. What do you think about the > >> >> attached patch to clarify the completing-read docstring? > >> > >> The use of a function as `require-match` is brand new in Emacs-29, so > >> I think it's not too late to fix it. I think rather than fixing the doc > >> we should fix the behavior, e.g. with the patch below. > > > > What change in behavior (wrt Emacs 29.1) does this patch cause? > > In the example he gave above it makes it so completion can be used to > insert "b" but when you try to exit it refuses to exit. > > IOW it gives primacy to the `require-match` function over the > completion-table w.r.t deciding when the minibuffer's content is > acceptable or not. > > Code which wants the 29.1 behavior can easily get it by modifying their > `require-match` function accordingly (and such code then works > correctly both with Emacs-29.1 and with the new behavior). Do we have any users of this feature in the tree?