unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 67310@debbugs.gnu.org, sbaugh@janestreet.com, juri@linkov.net
Subject: bug#67310: [PATCH] Include the project--list as history when prompting for a project
Date: Sat, 25 Nov 2023 17:57:10 +0200	[thread overview]
Message-ID: <83v89pbzc9.fsf@gnu.org> (raw)
In-Reply-To: <7a354d33-54b6-cc51-f9f4-58ee14380852@gutov.dev> (message from Dmitry Gutov on Sat, 25 Nov 2023 17:06:06 +0200)

> Date: Sat, 25 Nov 2023 17:06:06 +0200
> Cc: sbaugh@janestreet.com, 67310@debbugs.gnu.org, juri@linkov.net
> From: Dmitry Gutov <dmitry@gutov.dev>
> 
> On 25/11/2023 16:10, Eli Zaretskii wrote:
> >> Date: Sat, 25 Nov 2023 16:05:03 +0200
> >> Cc:sbaugh@janestreet.com,67310@debbugs.gnu.org,juri@linkov.net
> >> From: Dmitry Gutov<dmitry@gutov.dev>
> >>
> >>> I generally request and expect people not to make unnecessary changes,
> >>> since doing that makes forensics harder: you see changes which don't
> >>> change the code's semantics, and need to waste time studying such
> >>> "changes" and deciding that they are no-ops.
> >>>
> >>> Please everyone keep this in mind when you make changes.
> >> In general we don't frown in making minor cosmetic changes in the same
> >> area as major meaningful changes are done.
> > Yes, if the changes are for the better.  In this case, they seem to be
> > due to someone's personal stylistic preferences, so their value is
> > questionable at best.
> 
> I generally allow stylistic preferences when they don't run counter to 
> mine. That's better for contributors' morale, for one thing.

I suggest what I think is a better principle: the stylistic
preferences of the original author always take precedence.  This is
better both for the original author's morale (as in "something will
always be left of my contribution"), and for forensics, as I explained.

And I don't think this should hurt contributors' morale, since they
will know that their preferences in the code they introduce will be
kept for as long as the code is relevant, and not overwritten the next
day.





  reply	other threads:[~2023-11-25 15:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 19:58 bug#67310: [PATCH] Include the project--list as history when prompting for a project Spencer Baugh
2023-11-21 11:06 ` Dmitry Gutov
2023-11-21 11:14   ` Dmitry Gutov
2023-11-21 15:17     ` Spencer Baugh
2023-11-22  1:40       ` Dmitry Gutov
2023-11-22 16:18         ` Spencer Baugh
2023-11-22 18:44           ` Dmitry Gutov
2023-11-22 23:14             ` Spencer Baugh
2023-11-23  2:55               ` Dmitry Gutov
2023-11-24 15:50                 ` Spencer Baugh
2023-11-25  2:07                   ` Dmitry Gutov
2023-11-25 17:50                   ` Juri Linkov
2023-11-27 17:10                   ` Juri Linkov
2023-12-10  3:04                     ` Dmitry Gutov
2023-12-10 17:43                       ` Juri Linkov
2023-12-10 20:32                         ` Dmitry Gutov
2023-12-11 17:12                           ` Juri Linkov
2023-12-12  0:21                             ` Dmitry Gutov
2023-12-14  1:02                               ` sbaugh
2023-12-19 17:35                                 ` Juri Linkov
2023-11-23  6:38               ` Eli Zaretskii
2023-11-25  1:54                 ` Dmitry Gutov
2023-11-25  8:42                   ` Eli Zaretskii
2023-11-25 14:05                     ` Dmitry Gutov
2023-11-25 14:10                       ` Eli Zaretskii
2023-11-25 15:06                         ` Dmitry Gutov
2023-11-25 15:57                           ` Eli Zaretskii [this message]
2023-11-25 16:35                             ` Dmitry Gutov
2023-11-22  1:42       ` Dmitry Gutov
2023-11-22 16:21         ` Spencer Baugh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v89pbzc9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=67310@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=juri@linkov.net \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).