From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sat, 23 Dec 2023 13:51:10 +0200 Message-ID: <83v88pcf2p.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <83pm2a5k85.fsf@gnu.org> <87wmwh2tae.fsf@localhost> <83zg1d468w.fsf@gnu.org> <87bkdr2651.fsf@localhost> <87pm2584oz.fsf@localhost> <83cyy11ln1.fsf@gnu.org> <87lecp84mf.fsf@localhost> <83ttrdx8j9.fsf@gnu.org> <87a5su261p.fsf@localhost> <838r8e24yy.fsf@gnu.org> <87y1gezspg.fsf@localhost> <834jj21z05.fsf@gnu.org> <87il7izo4l.fsf@localhost> <831qe61xrh.fsf@gnu.org> <87cyxqzmhh.fsf@localhost> <83zg0uzlgw.fsf@gnu.org> <87v8bhxzcu.fsf@localhost> <83sf3te1tu.fsf@gnu.org> <87msu1qmqv.fsf@localhost> <83zfy1cgoa.fsf@gnu.org> <87le9lcg4e.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36960"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, monnier@iro.umontreal.ca To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 23 12:52:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rH0Y9-0009QV-Lf for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Dec 2023 12:52:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rH0Y2-00065m-0E; Sat, 23 Dec 2023 06:52:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rH0Xt-00065L-74 for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 06:51:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rH0Xs-0003ne-VQ for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 06:51:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rH0Xx-0004yJ-Sj for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 06:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Dec 2023 11:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170333229419072 (code B ref 66117); Sat, 23 Dec 2023 11:52:01 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 23 Dec 2023 11:51:34 +0000 Original-Received: from localhost ([127.0.0.1]:48744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH0XW-0004xX-45 for submit@debbugs.gnu.org; Sat, 23 Dec 2023 06:51:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH0XU-0004xI-5l for 66117@debbugs.gnu.org; Sat, 23 Dec 2023 06:51:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rH0XI-0003ja-AK; Sat, 23 Dec 2023 06:51:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8uS/Kocj7mq7rnC05vluEBhL7jTNieGApanMc0+mitk=; b=awrNb7V5M4wv IAzPfUX8qTSljGijXw3idJk9GC9ckamUWtk6/ZKaGLhmyYTEIwNyBk+4C8fW2tZ6BDUPx5fMnxBzW 0YsmyGZxQzcx75xbcS85dK/m7FMK1pGNL7NJz7yW/F24Qh47gTeB1IkCvSHYTUrnXVpPRhkqtkAtY lPlGh0SOpaGCPQYS72KhNcMbHp4qNVXN3OmQZF5SSmhBzSmESzaRozhVubdBWahb9IIWv1BuYtCuX I86C84CWwlf7bSsh/Ir2Cf8ZNXwxHmuJkNqlq8bTVFKs0wUE/Lcs7A4Z7i8Tfj+cMbBr2Ilpp+CaK h+QWDlIvzw6uvQ7AwiL6Pg==; In-Reply-To: <87le9lcg4e.fsf@localhost> (message from Ihor Radchenko on Sat, 23 Dec 2023 11:28:33 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276740 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, dmitry@gutov.dev, 66117@debbugs.gnu.org > Date: Sat, 23 Dec 2023 11:28:33 +0000 > > >> 3. Optionally add tests > > > > I hope the tests will not be optional... > > Didn't you say earlier that tests are not strictly necessary in > ? > > I do not mind adding tests, but it will not be as fast - I need help > with them. We could install just a few now, and the rest afterwards. You have already presented enough non-trivial cases that can be easily converted to tests, and I think it is a good idea to do that when we change such low-level and veteran code. So yes, it is not strictly necessary, but highly desirable.