From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#8435: misuse of error ("...%d...", ...) on 64-bit hosts Date: Sat, 09 Apr 2011 21:32:00 +0300 Message-ID: <83tye7s2cf.fsf@gnu.org> References: <4D9CC60D.2090301@cs.ucla.edu> <4D9D68D8.6060200@cs.ucla.edu> <8339ltvrok.fsf@gnu.org> <4D9E21FB.70802@cs.ucla.edu> <83vcypt8zf.fsf@gnu.org> <4D9F9B74.6050908@cs.ucla.edu> <83d3kvubzp.fsf@gnu.org> <4DA0A448.7000203@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1302374257 18865 80.91.229.12 (9 Apr 2011 18:37:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 9 Apr 2011 18:37:37 +0000 (UTC) Cc: 8435@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 09 20:37:29 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8d2G-00081N-Ti for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2011 20:37:29 +0200 Original-Received: from localhost ([127.0.0.1]:51793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8d2F-0007uR-Ts for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2011 14:37:27 -0400 Original-Received: from [140.186.70.92] (port=34854 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8d28-0007u9-Nd for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2011 14:37:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8d27-00034B-6v for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2011 14:37:20 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8d27-000342-58 for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2011 14:37:19 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q8czu-0001I9-Cd; Sat, 09 Apr 2011 14:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Apr 2011 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8435-submit@debbugs.gnu.org id=B8435.13023740924949 (code B ref 8435); Sat, 09 Apr 2011 18:35:02 +0000 Original-Received: (at 8435) by debbugs.gnu.org; 9 Apr 2011 18:34:52 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8czk-0001Hm-J9 for submit@debbugs.gnu.org; Sat, 09 Apr 2011 14:34:52 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8czh-0001HX-De for 8435@debbugs.gnu.org; Sat, 09 Apr 2011 14:34:50 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LJE00300E4QYN00@a-mtaout22.012.net.il> for 8435@debbugs.gnu.org; Sat, 09 Apr 2011 21:34:11 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.239.68]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LJE003G4E8TZQ00@a-mtaout22.012.net.il>; Sat, 09 Apr 2011 21:34:11 +0300 (IDT) In-reply-to: <4DA0A448.7000203@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 09 Apr 2011 14:35:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45715 Archived-At: > Date: Sat, 09 Apr 2011 11:24:08 -0700 > From: Paul Eggert > CC: 8435@debbugs.gnu.org > > > adding that support in other places has disadvantages that I > > mentioned in my previous message. > > The disadvantages are small compared to the advantages. Sorry, but I disagree. Instead of a single function that solved a couple of problems internally, we now have to solve those problems in users of that function, and we have to _remember_ that those problems might be solved. > Most of the changes in the patch are needed regardless > of whether doprnt is kept or discarded. I have no objections to those parts, as I wrote. > The part about > discarding doprnt shortens Emacs's code overall: it removes > 283 lines (doprnt itself, plus scaffolding) and adds 17 lines > (callers adjusting to the minor differences between doprnt > and vsnprintf). This is a clear win. I don't think line count is a compelling argument in favor of the change. > Part of the motivation here is that doprnt contains too many bugs. It cannot have too many real bugs, because it worked for so many years with little or no trouble. > it's wasteful to spend time maintaining a buggy near-copy of > vsnprintf. It's better software engineering practice to use > vsnprintf instead. Sorry, I don't agree.