From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12387: 24.2.50; File column printed by list-buffers is bad if done in dired-mode Date: Thu, 13 Sep 2012 20:07:38 +0300 Message-ID: <83txv1vokl.fsf@gnu.org> References: <5051A943.9030200@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1347556108 16119 80.91.229.3 (13 Sep 2012 17:08:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Sep 2012 17:08:28 +0000 (UTC) Cc: 12387@debbugs.gnu.org, emacs18@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 13 19:08:31 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TCCts-0007gN-Ox for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Sep 2012 19:08:24 +0200 Original-Received: from localhost ([::1]:59661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCCto-0005i5-Nw for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Sep 2012 13:08:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCCti-0005hv-66 for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2012 13:08:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCCtd-0004lu-Bm for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2012 13:08:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCCtd-0004lm-8G for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2012 13:08:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TCCuT-0004og-Jj for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2012 13:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Sep 2012 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12387-submit@debbugs.gnu.org id=B12387.134755611018476 (code B ref 12387); Thu, 13 Sep 2012 17:09:01 +0000 Original-Received: (at 12387) by debbugs.gnu.org; 13 Sep 2012 17:08:30 +0000 Original-Received: from localhost ([127.0.0.1]:60402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCCtw-0004nv-HF for submit@debbugs.gnu.org; Thu, 13 Sep 2012 13:08:29 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:52540) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCCtt-0004nn-OK for 12387@debbugs.gnu.org; Thu, 13 Sep 2012 13:08:27 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MAA00100SVDMM00@a-mtaout21.012.net.il> for 12387@debbugs.gnu.org; Thu, 13 Sep 2012 20:07:29 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAA001J4SWCHH60@a-mtaout21.012.net.il>; Thu, 13 Sep 2012 20:07:24 +0300 (IDT) In-reply-to: <5051A943.9030200@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64244 Archived-At: > Date: Thu, 13 Sep 2012 11:37:07 +0200 > From: martin rudalics > Cc: 12387@debbugs.gnu.org, emacs18@gmail.com > > Does the patch below fix it? > > martin > > === modified file 'src/xdisp.c' > --- src/xdisp.c 2012-09-12 00:14:50 +0000 > +++ src/xdisp.c 2012-09-13 09:31:34 +0000 > @@ -21039,8 +21039,7 @@ > : EQ (face, Qtool_bar) ? TOOL_BAR_FACE_ID > : DEFAULT_FACE_ID; > > - if (XBUFFER (buffer) != current_buffer) > - old_buffer = current_buffer; > + old_buffer = current_buffer; > > /* Save things including mode_line_proptrans_alist, > and set that to nil so that we don't alter the outer value. */ > @@ -21051,8 +21050,7 @@ > mode_line_proptrans_alist = Qnil; > > Fselect_window (window, Qt); > - if (old_buffer) > - set_buffer_internal_1 (XBUFFER (buffer)); > + set_buffer_internal_1 (XBUFFER (buffer)); > > init_iterator (&it, w, -1, -1, NULL, face_id); IMO, that's exactly what needs to be done. The attempts to avoid calling set_buffer_internal_1 are a classical case of premature optimization, since that function already knows how to avoid changing to the same buffer.