From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: 13007@debbugs.gnu.org, lekktu@gmail.com
Subject: bug#13007: 24.3.50; emacs_backtrace.txt
Date: Fri, 30 Nov 2012 18:59:47 +0200 [thread overview]
Message-ID: <83txs7t4ak.fsf@gnu.org> (raw)
In-Reply-To: <50B8D5E1.7090005@yandex.ru>
> Date: Fri, 30 Nov 2012 19:50:57 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> CC: 13007@debbugs.gnu.org, lekktu@gmail.com, drew.adams@oracle.com
>
> There is one more similar thing: if we can enter redisplay_internal
> with different current_buffer and selected window's buffer, we can
> confuse reconsider_clip_changes, which comment explicitly assumes
> that W->buffer and B are the same buffer.
I don't see that. That function checks if the buffer is the same as
the one recorded in window's matrix.
> What if we just delay the real redisplay action until current_buffer
> and selected window's buffer becomes synchronized, assuming that it
> happens in the very near future (when someone finally update current_buffer
> with selected window's buffer and then attract redisplay attention with
> ++windows_or_buffers_changed or similar)?
I don't think you can do that, since sometimes a non-selected window
needs to be redisplayed.
> IIUC pseudo-windows are always non-leaf; so, selected_window can't be
> a pseudo-window, and pseudo-window can't be passed to redisplay_window.
Are the menu-bar and tool-bar "windows" non-leaf?
> static void
> reconsider_clip_changes (struct window *w, struct buffer *b)
> {
> + eassert (XBUFFER (w->buffer) == b);
> +
How is this different from this:
> if (b->clip_changed
> && !NILP (w->window_end_valid)
> && w->current_matrix->buffer == b
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> + if (XBUFFER (w->buffer) != current_buffer)
> + /* Out of sync, do nothing. */
> + goto end_of_redisplay;
I'm nervous about this, to tell the truth. redisplay_internal never
dependent on current_buffer.
next prev parent reply other threads:[~2012-11-30 16:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 6:23 bug#13007: 24.3.50; emacs_backtrace.txt Drew Adams
2012-11-27 6:28 ` Drew Adams
2012-11-27 15:15 ` Eli Zaretskii
2012-11-27 15:41 ` Drew Adams
2012-11-27 15:44 ` Drew Adams
2012-11-27 16:39 ` Juanma Barranquero
2012-11-27 18:02 ` Eli Zaretskii
2012-11-27 15:14 ` Eli Zaretskii
2012-11-27 16:49 ` Dmitry Antipov
2012-11-27 17:47 ` Eli Zaretskii
2012-11-27 17:58 ` Jambunathan K
2012-11-27 18:10 ` Drew Adams
2012-11-28 7:19 ` Dmitry Antipov
2012-11-28 13:09 ` Juanma Barranquero
2012-11-28 15:51 ` Dmitry Antipov
2012-11-28 17:59 ` Eli Zaretskii
2012-11-29 6:19 ` Dmitry Antipov
2012-11-29 16:46 ` Eli Zaretskii
2012-11-29 17:02 ` Drew Adams
2012-11-29 17:39 ` Eli Zaretskii
2012-11-29 17:47 ` Drew Adams
2012-11-29 18:08 ` Eli Zaretskii
2012-11-29 18:13 ` Drew Adams
2012-11-29 19:50 ` Eli Zaretskii
2012-11-29 17:23 ` Dmitry Antipov
2012-11-30 9:53 ` Eli Zaretskii
2012-11-30 15:50 ` Dmitry Antipov
2012-11-30 16:59 ` Eli Zaretskii [this message]
2015-12-29 11:08 ` Lars Ingebrigtsen
2015-12-29 17:37 ` Eli Zaretskii
2016-01-02 11:10 ` Eli Zaretskii
2012-11-29 19:14 ` Stefan Monnier
2012-11-29 19:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83txs7t4ak.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13007@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).