From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14901: Trunk bootstrap broken Date: Fri, 19 Jul 2013 14:02:07 +0300 Message-ID: <83txjqzuc0.fsf@gnu.org> References: <51E84B16.8000008@alice.it> <51E869E2.4070203@alice.it> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1374231857 3035 80.91.229.3 (19 Jul 2013 11:04:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Jul 2013 11:04:17 +0000 (UTC) Cc: 14901@debbugs.gnu.org, angelo.graziosi@alice.it To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 19 13:04:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V08Tr-0004Fq-WC for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Jul 2013 13:04:12 +0200 Original-Received: from localhost ([::1]:36226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V08Tr-00071Z-K8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Jul 2013 07:04:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V08Tk-00071R-6D for bug-gnu-emacs@gnu.org; Fri, 19 Jul 2013 07:04:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V08Ti-0002RX-U3 for bug-gnu-emacs@gnu.org; Fri, 19 Jul 2013 07:04:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V08Ti-0002RM-Pq for bug-gnu-emacs@gnu.org; Fri, 19 Jul 2013 07:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V08Ti-0006Fl-6I for bug-gnu-emacs@gnu.org; Fri, 19 Jul 2013 07:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Jul 2013 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14901 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14901-submit@debbugs.gnu.org id=B14901.137423178823848 (code B ref 14901); Fri, 19 Jul 2013 11:04:02 +0000 Original-Received: (at 14901) by debbugs.gnu.org; 19 Jul 2013 11:03:08 +0000 Original-Received: from localhost ([127.0.0.1]:36872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V08Sp-0006Ca-El for submit@debbugs.gnu.org; Fri, 19 Jul 2013 07:03:07 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:53997) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V08Sl-0006Bb-Ta for 14901@debbugs.gnu.org; Fri, 19 Jul 2013 07:03:05 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MQ600C00JW8V400@a-mtaout22.012.net.il> for 14901@debbugs.gnu.org; Fri, 19 Jul 2013 14:01:56 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQ600CC1JZ7NA20@a-mtaout22.012.net.il>; Fri, 19 Jul 2013 14:01:56 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76476 Archived-At: > From: Juanma Barranquero > Date: Fri, 19 Jul 2013 01:17:13 +0200 > Cc: 14901@debbugs.gnu.org > > > After Paul's changes, rev. 113451 bootstraps... Thanks. > > Yes, I just saw. Wonderful. Not so wonderful. (Doesn't anyone watch compiler warnings these days?) Using this: struct x_display_info *di; on anything but X11 is a no-no, since that struct is not portable. The portable way is to use Display_Info, which a type defined on any platform we support (including TTYs and even MS-DOS). No need for the DISPLAY_INFO macro, either. > But in ay case, could you please test that it works by changing WINDOWSNT > to HAVE_NTGUI in that #ifdef? I think it's the right test anyway. This whole rigmarole with multiple HAVE_* is not needed at all, since HAVE_WINDOW_SYSTEM captures all of them. I fixed both of the above in trunk revision 113456. I've verified this to compile on GNU/Linux and on MS-Windows, I expect the NS port will build without any problems, too.