From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20369: Rendering problems and fill column Date: Sun, 19 Apr 2015 19:54:53 +0300 Message-ID: <83twwc5a8y.fsf@gnu.org> References: <87mw2430ex.fsf@opmbx.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1429462585 24182 80.91.229.3 (19 Apr 2015 16:56:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 19 Apr 2015 16:56:25 +0000 (UTC) Cc: 20369@debbugs.gnu.org To: Mark Karpov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 19 18:56:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YjsVv-0007Gr-5e for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Apr 2015 18:56:11 +0200 Original-Received: from localhost ([::1]:49129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjsVu-0007uD-Kf for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Apr 2015 12:56:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjsVq-0007u5-Mb for bug-gnu-emacs@gnu.org; Sun, 19 Apr 2015 12:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjsVm-0000T7-Hj for bug-gnu-emacs@gnu.org; Sun, 19 Apr 2015 12:56:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjsVm-0000T3-E8 for bug-gnu-emacs@gnu.org; Sun, 19 Apr 2015 12:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YjsVl-0001He-U6 for bug-gnu-emacs@gnu.org; Sun, 19 Apr 2015 12:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Apr 2015 16:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20369 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20369-submit@debbugs.gnu.org id=B20369.14294625114875 (code B ref 20369); Sun, 19 Apr 2015 16:56:01 +0000 Original-Received: (at 20369) by debbugs.gnu.org; 19 Apr 2015 16:55:11 +0000 Original-Received: from localhost ([127.0.0.1]:60839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjsUx-0001GY-6U for submit@debbugs.gnu.org; Sun, 19 Apr 2015 12:55:11 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:52387) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjsUu-0001G6-Cf for 20369@debbugs.gnu.org; Sun, 19 Apr 2015 12:55:09 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NN200500C5NJO00@mtaout28.012.net.il> for 20369@debbugs.gnu.org; Sun, 19 Apr 2015 19:53:48 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NN200AF0C9OEG90@mtaout28.012.net.il>; Sun, 19 Apr 2015 19:53:48 +0300 (IDT) In-reply-to: <87mw2430ex.fsf@opmbx.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101725 Archived-At: > From: Mark Karpov > Date: Sun, 19 Apr 2015 15:57:58 +0600 > > I use `fill-column-indicator' package, however, it introduces some > rendering problems Which ones, specifically? They aren't necessarily one and the same problem, so detailed bug reports with recipes for reproduction are welcome. Some of the problems were already discussed, see bug #18417 and the emacs-devel thread referenced there. > see this issue for example (other issues are also known): > > https://github.com/alpaker/Fill-Column-Indicator/issues/58 > > It may seem to be not a problem of vanilla Emacs, but the author of the > package says: > > > This appears to be a regression in Emacs's display engine's handling > > of cursor text properties. I'll look into isolating the underlying > > issue and filing a bug report. I'll report back here (and close this > > issue) after doing so. > > Not sure if he did so or not. He didn't, AFAICS (his last message was posted in November 2014). > If it's really a regression in Emacs's display engine, can we hope > that it will be fixed in Emacs 25? This particular issue not a display problem, it's a genuine problem with fci-mode vis-à-vis Dired. Fci-mode puts overlays on the end of each line; when you invoke dired-revert, that function calls erase-buffer, which deletes all of the text from the buffer, but leaves the overlays, all of them now crowded at buffer position 1. Then Dired re-inserts the directory into the buffer, but fci-mode's hooks that trigger re-computation of the overlays don't catch this particular case, so the old overlays are left in place, and redisplay shows them. You can work around this by using the quick-and-dirty fix below, although it's gross: it will trigger re-computation of fci-mode overlays in all the windows on the frame each time you type 'g'. So a better fix is necessary, IMO. > Also, in my opinion, indication of fill column must be a built-in > feature, because it's even more important than indication of empty > lines at the end of file (which is implemented). I agree; patches to do that are welcome. Here's the patch I promised: --- fill-column-indicator.el~ 2015-04-19 13:44:54 +0300 +++ fill-column-indicator.el 2015-04-19 15:17:03 +0300 @@ -393,6 +393,7 @@ '((after-change-functions fci-redraw-region t t) (before-change-functions fci-extend-rule-for-deletion nil t) (window-scroll-functions fci-update-window-for-scroll nil t) + (dired-after-readin-hook fci-redraw-frame) (window-configuration-change-hook fci-redraw-frame) (post-command-hook fci-post-command-check nil t) (change-major-mode-hook turn-off-fci-mode nil t)