From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Date: Mon, 29 Jun 2015 18:26:38 +0300 Message-ID: <83twtq4jtd.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> <8361666035.fsf@gnu.org> <55915DE6.3030108@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1435591645 443 80.91.229.3 (29 Jun 2015 15:27:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Jun 2015 15:27:25 +0000 (UTC) Cc: 20728@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 29 17:27:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z9axl-0002wP-O3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jun 2015 17:27:13 +0200 Original-Received: from localhost ([::1]:42740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9axk-0000Fu-QT for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jun 2015 11:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9axg-0000EO-QB for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 11:27:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9axa-0001Cg-J5 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 11:27:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9axa-0001CW-GW for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 11:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z9axa-0008Ni-9C for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 11:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143559160632198 (code B ref 20728); Mon, 29 Jun 2015 15:27:02 +0000 Original-Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 15:26:46 +0000 Original-Received: from localhost ([127.0.0.1]:33122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9axJ-0008NF-4z for submit@debbugs.gnu.org; Mon, 29 Jun 2015 11:26:46 -0400 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:36951) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9axG-0008N2-Gl for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 11:26:43 -0400 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NQP00B00P11ZR00@mtaout27.012.net.il> for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 18:22:49 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQP009DHPE1Q240@mtaout27.012.net.il>; Mon, 29 Jun 2015 18:22:49 +0300 (IDT) In-reply-to: <55915DE6.3030108@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104495 Archived-At: > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Mon, 29 Jun 2015 18:01:58 +0300 > > >> Whether we want a given command to use a colorized Grep output, is not > >> dependent on the OS, is it? > > > > I don't think so. But it might depend on the values of grep-program > > etc., i.e. on user customizations. Users might want to put shell > > scripts or pipelines there. > > Well, okay. If it's a significant use case, we might want to continue > supporting it. I don't know if it's a significant use case. Maybe it isn't, and we should just go ahead and do what you suggest. > On the other hand, we might want to choose to set > `grep-highlight-matches' to `always' in grep-compute-defaults, > irrespective of the OS. Won't that bring back the problem in symref/grep.el again? > So that every command that knows it does not need the ANSI codes, will > bind this variable to nil without relying on auto-detection thanks to > calling Grep via a pipe. Then we won't have to test on Windows to find > bugs like that. Assuming we can count on commands that live far away, like symref/grep.el, to make a point of doing this, it will work, of course. > And if a user customized grep-program, etc, to unexpectedly postprocess > Grep ouput using a pipe, they can customize `grep-highlight-matches' to > `auto' as well. Yes, given enough documentation that mentions this.