From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 19576@debbugs.gnu.org, andlind@gmail.com
Subject: bug#19576: write-file writes the wrong buffer
Date: Thu, 19 Nov 2015 17:44:54 +0200 [thread overview]
Message-ID: <83twoi803t.fsf@gnu.org> (raw)
In-Reply-To: <564D8482.20804@gmx.at>
> Date: Thu, 19 Nov 2015 09:12:50 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: andlind@gmail.com, 19576@debbugs.gnu.org
>
> > Thanks for working on this, Martin. However, I don't think we should
> > install this change. We call Lisp hooks from many places, including
> > maybe a dozen in the display engine. It makes little sense to make
> > only one of them resistant to this kind of problems. OTOH, if we do
> > this everywhere, I feel that we will unduly punish 99.999% percent of
> > legitimate users of these hooks just because one of them had a bug.
>
> 100% agreed. But run_window_configuration_change_hook goes a long way
> saving and restoring current buffer and selected window around each call
> to a function on ‘window-configuration-change-hook’.
That function isn't called by the display engine, but only by a
handful of functions that react to changes in windows. So I really
don't consider that to be an analogous case, sorry.
> People who put their functions on ‘window-size-change-functions’ and
> ‘window-configuration-change-hook’ usually don't care about the precise
> reason why these function get called. They simply want to cover all
> cases where a new window appears or a specific window changes size. Do
> we really expect them to add a ‘save-window-excursion’ in one case and
> avoid it in the other because it would mean unnecessary extra work?
Yes, we do. Hooks called by the display engine should be coded very
carefully, because they are a large part of that proverbial rope that
Emacs gives us to hang ourselves. If they don't write those hooks
with great care, they get what they deserve.
next prev parent reply other threads:[~2015-11-19 15:44 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 23:37 bug#19576: 24.4; Broken function in `window-size-change-functions' cause `write-file' to write the wrong buffer Anders Lindgren
2015-11-16 19:18 ` bug#19576: write-file writes " Anders Lindgren
2015-11-16 19:46 ` martin rudalics
2015-11-16 20:05 ` Anders Lindgren
2015-11-17 0:55 ` Juri Linkov
2015-11-17 20:02 ` Alan Mackenzie
2015-11-17 21:52 ` Anders Lindgren
2015-11-18 0:27 ` Juri Linkov
2015-11-18 1:37 ` Drew Adams
2015-11-18 7:54 ` Anders Lindgren
2015-11-18 17:45 ` Eli Zaretskii
2015-11-18 23:23 ` Alan Mackenzie
2015-11-19 16:03 ` Eli Zaretskii
2015-11-20 8:22 ` martin rudalics
2015-11-20 10:17 ` Eli Zaretskii
2015-11-20 10:48 ` martin rudalics
2015-11-20 11:16 ` Eli Zaretskii
2015-11-20 11:25 ` martin rudalics
2015-11-20 11:40 ` Eli Zaretskii
2015-11-20 14:21 ` martin rudalics
2015-11-20 14:54 ` Eli Zaretskii
2015-11-21 11:35 ` Eli Zaretskii
2015-11-21 15:56 ` Alan Mackenzie
2015-11-21 16:01 ` Eli Zaretskii
2015-11-21 16:49 ` Anders Lindgren
2015-11-21 17:10 ` Eli Zaretskii
2015-11-21 18:27 ` martin rudalics
2015-11-21 18:33 ` Eli Zaretskii
2015-11-21 18:44 ` martin rudalics
2015-11-21 19:08 ` Eli Zaretskii
2015-11-21 20:33 ` Anders Lindgren
2015-11-22 10:44 ` martin rudalics
2015-11-22 15:36 ` Eli Zaretskii
2015-11-21 16:02 ` bug#21333: " Eli Zaretskii
2015-11-22 11:08 ` martin rudalics
2015-11-22 15:39 ` Eli Zaretskii
2015-11-22 17:46 ` martin rudalics
2015-11-23 18:21 ` Eli Zaretskii
2015-11-23 18:28 ` Alan Mackenzie
2015-11-24 8:27 ` martin rudalics
2015-11-24 16:19 ` Eli Zaretskii
2015-11-28 10:26 ` martin rudalics
2015-11-28 11:27 ` Eli Zaretskii
2015-11-30 13:30 ` martin rudalics
2015-11-30 16:28 ` Eli Zaretskii
2015-11-30 17:27 ` martin rudalics
2015-11-19 8:13 ` martin rudalics
2015-11-19 15:45 ` Eli Zaretskii
2015-11-20 8:22 ` martin rudalics
2015-11-20 8:34 ` Eli Zaretskii
2015-11-20 10:25 ` martin rudalics
2015-11-20 11:15 ` Eli Zaretskii
2015-11-20 11:25 ` martin rudalics
2015-11-20 11:39 ` Eli Zaretskii
2015-11-20 14:21 ` martin rudalics
2015-11-20 11:32 ` Alan Mackenzie
2015-11-20 11:41 ` Eli Zaretskii
2015-11-17 21:15 ` Anders Lindgren
2015-11-18 17:52 ` Eli Zaretskii
2015-11-18 19:23 ` Anders Lindgren
2015-11-18 20:52 ` Eli Zaretskii
2015-11-19 2:06 ` John Wiegley
2015-11-19 6:54 ` Anders Lindgren
2015-11-19 15:31 ` Eli Zaretskii
2015-11-22 18:44 ` Johan Bockgård
2015-11-22 18:55 ` Johan Bockgård
2015-11-22 19:02 ` Eli Zaretskii
2015-11-17 8:34 ` martin rudalics
2015-11-17 19:08 ` Anders Lindgren
2015-11-18 17:24 ` Eli Zaretskii
2015-11-19 8:12 ` martin rudalics
2015-11-19 15:44 ` Eli Zaretskii [this message]
2015-11-20 8:22 ` martin rudalics
2015-11-20 8:32 ` Eli Zaretskii
[not found] ` <mailman.9.1447720293.31583.bug-gnu-emacs@gnu.org>
2015-11-17 22:10 ` Alan Mackenzie
2015-11-18 7:09 ` martin rudalics
2015-11-20 20:17 ` bug#19576: Fixed: " Anders Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83twoi803t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=19576@debbugs.gnu.org \
--cc=andlind@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).