From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22323: Font fallback causes inconsistent stacking of faces in overlays with invisible property Date: Fri, 08 Jan 2016 12:22:52 +0200 Message-ID: <83twmopdz7.fsf@gnu.org> References: <568E97E7.2030604@live.com> <831t9t2qrv.fsf@gnu.org> <568F0E9D.3070200@live.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1452248668 29908 80.91.229.3 (8 Jan 2016 10:24:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Jan 2016 10:24:28 +0000 (UTC) Cc: 22323-done@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 08 11:24:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aHUDM-00023L-QK for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jan 2016 11:24:12 +0100 Original-Received: from localhost ([::1]:34908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHUDM-0000re-75 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jan 2016 05:24:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHUDI-0000oi-Di for bug-gnu-emacs@gnu.org; Fri, 08 Jan 2016 05:24:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHUDF-0004Q9-0n for bug-gnu-emacs@gnu.org; Fri, 08 Jan 2016 05:24:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHUDE-0004PX-Tm for bug-gnu-emacs@gnu.org; Fri, 08 Jan 2016 05:24:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aHUDC-0008Cn-Gx for bug-gnu-emacs@gnu.org; Fri, 08 Jan 2016 05:24:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jan 2016 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 22323 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 22323@debbugs.gnu.org, eliz@gnu.org, clement.pitclaudel@live.com Original-Received: via spool by 22323-done@debbugs.gnu.org id=D22323.145224859531480 (code D ref 22323); Fri, 08 Jan 2016 10:24:02 +0000 Original-Received: (at 22323-done) by debbugs.gnu.org; 8 Jan 2016 10:23:15 +0000 Original-Received: from localhost ([127.0.0.1]:42283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aHUCR-0008Bg-IS for submit@debbugs.gnu.org; Fri, 08 Jan 2016 05:23:15 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54505) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aHUCP-0008BR-W2 for 22323-done@debbugs.gnu.org; Fri, 08 Jan 2016 05:23:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHUCH-0004LJ-IA for 22323-done@debbugs.gnu.org; Fri, 08 Jan 2016 05:23:08 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHUCH-0004LF-EP; Fri, 08 Jan 2016 05:23:05 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1220 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aHUC7-0007yQ-KT; Fri, 08 Jan 2016 05:23:02 -0500 In-reply-to: <568F0E9D.3070200@live.com> (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel on Thu, 7 Jan 2016 20:19:25 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111365 Archived-At: > Cc: 22323@debbugs.gnu.org > From: Clément Pit--Claudel > Date: Thu, 7 Jan 2016 20:19:25 -0500 > > > Here's a suggestion: ignore the face of the invisible text altogether, > > and instead always use the face of the last visible character. The > > patch to do that is below; it fixes all of your test cases. But since > > you would like to see the face of the invisible text show through, I'm > > not sure you will like it... > > > > WDYT? > > I like it :) I find it much more consistent that what we currently have. Plus, > has a desirable property that you pointed out and that I agree with, that the > properties of the invisible text do not affect the display of the ellipsis. The > current implementation doesn't have that property (adding a face to a hidden > character will cause the ellipsis to change to the default face), so I think > it's a net gain. Thanks, I pushed it, and I'm marking these 2 bugs as done. > (In fact, I'm even a bit surprised that it handles the selection and font > fallback cases properly. It's great that it does though; but did I apply the > patch incorrectly?) Yes, you applied correctly. The default ellipsis uses ASCII characters, so I think the fallback font doesn't affect them.