From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: ofv@wanadoo.es, 22356@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#22356: 25.0.50; emacs-25 very crashy with ivy-mode
Date: Sat, 16 Jan 2016 12:03:35 +0200 [thread overview]
Message-ID: <83twmdet8o.fsf@gnu.org> (raw)
In-Reply-To: <569A0BED.4080000@gmx.at> (message from martin rudalics on Sat, 16 Jan 2016 10:22:53 +0100)
> Date: Sat, 16 Jan 2016 10:22:53 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: 22356@debbugs.gnu.org
>
> > We weren't assigning space for glyphs of the margins in the
> > mini-window. Why? because of a single typo (or thinko?) more than 2
> > years ago! That typo made us think the mini-window has a very large
> > total width in column units:
> >
> > emacs -Q
> > M-: (window-total-width (minibuffer-window)) RET
> > => 672
> >
> > That preposterous value then defeated the logic in the display engine
> > which decides how many glyphs are needed for displaying stuff in the
> > margin, when margins are turned on in a window: that logic decided the
> > correct number was zero. And from there it's a quick path to writing
> > beyond the allocated memory.
>
> Thanks for fixing my silly oversight.
Stuff happens ;-)
> margin_glyphs_to_reserve is the only client of the total_cols slot
> of the minibuffer window, so there's no wonder that this bug
> remained undetected for such a long time.
margin_glyphs_to_reserve also had a flaw: it could return zero for
positive values of the MARGIN argument, which is clearly wrong. I
fixed that with a follow-up patch, so now it always returns at least 1
column when the margin is non-zero.
next prev parent reply other threads:[~2016-01-16 10:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 12:59 bug#22356: 25.0.50; emacs-25 very crashy with ivy-mode Dmitry Gutov
[not found] ` <handler.22356.B.145260358930042.ack@debbugs.gnu.org>
2016-01-12 13:04 ` bug#22356: Acknowledgement (25.0.50; emacs-25 very crashy with ivy-mode) Dmitry Gutov
2016-01-12 16:01 ` Eli Zaretskii
2016-01-12 16:11 ` Dmitry Gutov
2016-01-12 18:25 ` Eli Zaretskii
2016-01-12 14:26 ` bug#22356: 25.0.50; emacs-25 very crashy with ivy-mode Dmitry Gutov
2016-01-12 16:05 ` Eli Zaretskii
2016-01-12 16:48 ` Dmitry Gutov
2016-01-12 18:33 ` Eli Zaretskii
2016-01-12 22:27 ` Dmitry Gutov
2016-01-13 0:21 ` Dmitry Gutov
2016-01-13 1:10 ` Óscar Fuentes
2016-01-13 1:15 ` Óscar Fuentes
2016-01-13 1:22 ` Dmitry Gutov
2016-01-13 1:36 ` Óscar Fuentes
2016-01-15 15:23 ` Eli Zaretskii
2016-01-16 9:22 ` martin rudalics
2016-01-16 10:03 ` Eli Zaretskii [this message]
2016-01-15 15:24 ` Eli Zaretskii
2016-01-15 16:06 ` Óscar Fuentes
2016-01-15 16:19 ` Eli Zaretskii
2016-01-15 22:47 ` Dmitry Gutov
2016-01-16 6:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83twmdet8o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22356@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=ofv@wanadoo.es \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).