From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env Date: Fri, 17 Jun 2016 20:06:28 +0300 Message-ID: <83twgrbv8r.fsf@gnu.org> References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466185704 5783 80.91.229.3 (17 Jun 2016 17:48:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2016 17:48:24 +0000 (UTC) Cc: npostavs@users.sourceforge.net, 23779@debbugs.gnu.org, schwab@linux-m68k.org, eggert@cs.ucla.edu To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 17 19:48:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDxsJ-0005Nc-Dp for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 19:48:11 +0200 Original-Received: from localhost ([::1]:59416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxsI-0002ZG-Bi for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 13:48:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxDb-0005JL-Nz for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 13:06:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDxDV-0001RP-TI for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 13:06:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxDV-0001RL-Qb for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 13:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDxDV-00029S-L2 for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 13:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2016 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23779-submit@debbugs.gnu.org id=B23779.14661831418240 (code B ref 23779); Fri, 17 Jun 2016 17:06:01 +0000 Original-Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 17:05:41 +0000 Original-Received: from localhost ([127.0.0.1]:44452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDxDA-00028q-NJ for submit@debbugs.gnu.org; Fri, 17 Jun 2016 13:05:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDxD8-00028c-C5 for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 13:05:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDxCy-0001M6-JB for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 13:05:33 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxCy-0001Lk-Fh; Fri, 17 Jun 2016 13:05:28 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4548 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bDxCw-0006jr-FL; Fri, 17 Jun 2016 13:05:26 -0400 In-reply-to: <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> (message from Dmitry Gutov on Fri, 17 Jun 2016 17:47:49 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119678 Archived-At: > Cc: npostavs@users.sourceforge.net, 23779@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 17 Jun 2016 17:47:49 +0300 > > On 06/17/2016 05:19 PM, Eli Zaretskii wrote: > > >> I wonder if we should make setenv work non-destructively now. > > > > Why should we do that? We have initial-environment if we need the > > original value. > > Normally, we only want to change the environment for the duration of a > command. Now that 'push' works, why do we need setenv for that? > So, what are the downsides? That there's no way of changing the environment permanently? > - We won't have to cons manually anymore. The code will become a bit > nicer, like: > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index f35c84d..5315e0a 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1450,7 +1450,8 @@ vc-git--call > (or coding-system-for-read vc-git-log-output-coding-system)) > (coding-system-for-write > (or coding-system-for-write vc-git-commits-coding-system)) > - (process-environment (cons "PAGER=" process-environment))) > + (process-environment process-environment)) > + (setenv "PAGER") I'm not sure I see why that is nicer.