From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23785: Emacs 25: 'Undo' overdoes things. Date: Tue, 21 Jun 2016 19:13:10 +0300 Message-ID: <83twgm5xm1.fsf@gnu.org> References: <20160617150245.GB3316@acm.fritz.box> <83r3bvbuu1.fsf@gnu.org> <20160617174535.GD3316@acm.fritz.box> <83oa6zbmvd.fsf@gnu.org> <87ziqjwkrb.fsf@russet.org.uk> <83eg7vaq3z.fsf@gnu.org> <83bn2y9v80.fsf@gnu.org> <87vb13ewc8.fsf@russet.org.uk> <83eg7q7k9b.fsf@gnu.org> <87ziqety1w.fsf@russet.org.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466525735 6337 80.91.229.3 (21 Jun 2016 16:15:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Jun 2016 16:15:35 +0000 (UTC) Cc: acm@muc.de, 23785@debbugs.gnu.org, monnier@iro.umontreal.ca To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 21 18:15:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFOKX-0004ZA-4r for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jun 2016 18:15:13 +0200 Original-Received: from localhost ([::1]:52901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOKW-0002bN-9M for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jun 2016 12:15:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOKP-0002Z4-PR for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 12:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFOKL-0001Rj-SQ for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 12:15:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOKL-0001Rf-P7 for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 12:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFOKL-0007vR-ME for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 12:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jun 2016 16:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23785-submit@debbugs.gnu.org id=B23785.146652565930405 (code B ref 23785); Tue, 21 Jun 2016 16:15:01 +0000 Original-Received: (at 23785) by debbugs.gnu.org; 21 Jun 2016 16:14:19 +0000 Original-Received: from localhost ([127.0.0.1]:49988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFOJb-0007uG-US for submit@debbugs.gnu.org; Tue, 21 Jun 2016 12:14:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFOJa-0007u4-UC for 23785@debbugs.gnu.org; Tue, 21 Jun 2016 12:14:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFOJR-0001DM-Gd for 23785@debbugs.gnu.org; Tue, 21 Jun 2016 12:14:09 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOJR-0001D6-Di; Tue, 21 Jun 2016 12:14:05 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4994 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bFOJP-00079T-7u; Tue, 21 Jun 2016 12:14:03 -0400 In-reply-to: <87ziqety1w.fsf@russet.org.uk> (phillip.lord@russet.org.uk) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119897 Archived-At: > From: phillip.lord@russet.org.uk (Phillip Lord) > Cc: monnier@iro.umontreal.ca, acm@muc.de, 23785@debbugs.gnu.org > Date: Tue, 21 Jun 2016 15:29:47 +0100 > > This one, to master. > > >From 2ab1f314ad6fe0e68420cc510445495467d82b8f Mon Sep 17 00:00:00 2001 > From: Phillip Lord > Date: Fri, 17 Jun 2016 22:34:50 +0100 > Subject: [PATCH] Fix missing undo-boundary after revert-buffer > > * lisp/simple.el (undo-auto--boundaries): Ensure an undo-boundary after > every command whether it (apparently) changes the buffer or not. > > Addresses Bug#23785 > --- > lisp/simple.el | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lisp/simple.el b/lisp/simple.el > index b66827d..3110430 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -2875,6 +2875,10 @@ undo-auto--boundaries > "Check recently changed buffers and add a boundary if necessary. > REASON describes the reason that the boundary is being added; see > `undo-last-boundary' for more information." > + ;; (Bug #23785) All commands should ensure that there is an undo > + ;; boundary whether they have changed the current buffer or not. > + (when (eq cause 'command) > + (add-to-list 'undo-auto--undoably-changed-buffers (current-buffer))) > (dolist (b undo-auto--undoably-changed-buffers) > (when (buffer-live-p b) > (with-current-buffer b OK.