From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24089: 25.1; Dired: diff error on = if the file has a backup inside .~/ Date: Sat, 06 Aug 2016 13:18:50 +0300 Message-ID: <83tweyjj3p.fsf@gnu.org> References: <1469644946.16323.9.camel@gmail.com> <83popxrefr.fsf@gnu.org> <1469792610.16323.47.camel@gmail.com> <83bn1gqzco.fsf@gnu.org> <1469809763.28832.14.camel@gmail.com> <838twhq1zb.fsf@gnu.org> <1470189864.29404.3.camel@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1470478823 4155 195.159.176.226 (6 Aug 2016 10:20:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 Aug 2016 10:20:23 +0000 (UTC) Cc: 24089-done@debbugs.gnu.org To: Jorge Peixoto de Morais Neto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 06 12:20:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVyiI-0000HD-AF for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Aug 2016 12:20:18 +0200 Original-Received: from localhost ([::1]:48738 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVyiF-0001XD-4G for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Aug 2016 06:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVyi5-0001UX-U7 for bug-gnu-emacs@gnu.org; Sat, 06 Aug 2016 06:20:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVyi2-0008UO-88 for bug-gnu-emacs@gnu.org; Sat, 06 Aug 2016 06:20:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVyi2-0008UI-5X for bug-gnu-emacs@gnu.org; Sat, 06 Aug 2016 06:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bVyi1-0000FJ-V9 for bug-gnu-emacs@gnu.org; Sat, 06 Aug 2016 06:20:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Aug 2016 10:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24089 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 24089@debbugs.gnu.org, eliz@gnu.org, jorge13515@gmail.com Original-Received: via spool by 24089-done@debbugs.gnu.org id=D24089.1470478747874 (code D ref 24089); Sat, 06 Aug 2016 10:20:01 +0000 Original-Received: (at 24089-done) by debbugs.gnu.org; 6 Aug 2016 10:19:07 +0000 Original-Received: from localhost ([127.0.0.1]:57141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVyh8-0000E2-VI for submit@debbugs.gnu.org; Sat, 06 Aug 2016 06:19:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVyh7-0000DV-4m for 24089-done@debbugs.gnu.org; Sat, 06 Aug 2016 06:19:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVygy-0008Lj-NL for 24089-done@debbugs.gnu.org; Sat, 06 Aug 2016 06:18:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVygy-0008KE-Kh; Sat, 06 Aug 2016 06:18:56 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1849 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bVygw-0000Im-Jf; Sat, 06 Aug 2016 06:18:55 -0400 In-reply-to: <1470189864.29404.3.camel@gmail.com> (message from Jorge Peixoto de Morais Neto on Tue, 02 Aug 2016 23:04:24 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121885 Archived-At: > From: Jorge Peixoto de Morais Neto > Cc: 24089@debbugs.gnu.org > Date: Tue, 02 Aug 2016 23:04:24 -0300 > > On Sun, 2016-07-31 at 18:08 +0300, Eli Zaretskii wrote: > > How about the alternative patch below?  It fixes the doc string, and > > makes the prompt be without the default in the second case.  Is that > > good enough, in your opinion? > > This new patch is better.  This is already good.  There is one more tweak that > maybe could make it even better: with this latest patch, if the user types = > in the backup file then Emacs says >    Attempt to compare the file to itself The same happens in other situations when there's no default dired-diff can intuit. So this behavior is not new to dired-diff. > Wouldn't it be better if dired-diff refused the minibuffer input if it is not > a valid file?  This way, if the user types = , Emacs will display "[no > match]", which would be more precise. No, I think the "[No match]" thing is worse: it leaves the user wondering what it means. (Match for what?) I believe the fact that there's no default value is a hint good enough for the user to become aware that she must type something. I committed the patch to the master branch, and I'm marking this bug done. Thanks a lot for reporting this subtle bug and for testing the fixes.