From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25046: 26.0.50; Arguments of `ediff-janitor' undocumented Date: Fri, 02 Dec 2016 16:37:48 +0200 Message-ID: <83twammm6b.fsf@gnu.org> References: <837f7ioez6.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1480689501 16444 195.159.176.226 (2 Dec 2016 14:38:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 14:38:21 +0000 (UTC) Cc: 25046@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 02 15:38:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoya-00032Q-K2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 15:38:12 +0100 Original-Received: from localhost ([::1]:34868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCoye-0005QZ-Jy for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 09:38:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCoyU-0005QG-CW for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 09:38:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCoyQ-00062b-Hf for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 09:38:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34254) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCoyQ-00062U-Ev for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 09:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cCoyQ-0006om-6G for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 09:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2016 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25046-submit@debbugs.gnu.org id=B25046.148068947726198 (code B ref 25046); Fri, 02 Dec 2016 14:38:02 +0000 Original-Received: (at 25046) by debbugs.gnu.org; 2 Dec 2016 14:37:57 +0000 Original-Received: from localhost ([127.0.0.1]:49653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoyK-0006oT-OF for submit@debbugs.gnu.org; Fri, 02 Dec 2016 09:37:56 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoyI-0006oG-Sk for 25046@debbugs.gnu.org; Fri, 02 Dec 2016 09:37:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCoy8-0005zW-VT for 25046@debbugs.gnu.org; Fri, 02 Dec 2016 09:37:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCoy8-0005zH-Rg; Fri, 02 Dec 2016 09:37:44 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1697 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCoy4-0000pD-Kq; Fri, 02 Dec 2016 09:37:41 -0500 In-reply-to: (message from Philipp Stephani on Fri, 02 Dec 2016 13:47:33 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126412 Archived-At: > From: Philipp Stephani > Date: Fri, 02 Dec 2016 13:47:33 +0000 > Cc: 25046-done@debbugs.gnu.org > > Thanks, however I'm still not quite sure about the meaning. > "ASK non-nil means ask the user whether to keep each unmodified buffer, unless KEEP-VARIANTS is > non-nil, in which case buffers are killed unconditionally." > So if ASK = nil, KEEP-VARIANTS = nil: kill buffers, don't ask about any buffer Yes. > ASK = (nil or non-nil), KEEP-VARIANTS = non-nil: don't kill any buffer, don't ask Yes, I've goofed. KEEP-VARIANTS non-nil means never kill. Now fixed. > ASK = non-nil, KEEP-VARIANTS = nil: ask about each buffer Yes. > If that's the case, shouldn't the documentation rather be something like: > "If KEEP-VARIANTS is non-nil, only indirect buffers are killed [what does that mean for the user?], and ASK is > ignored. Otherwise, if ASK is non-nil, ask the user for each unmodified buffer whether it should be killed. > Otherwise (both ASK and KEEP-VARIANTS) are nil, all unmodified buffers are killed without confirmation." > WDYT? I don't think mentioning indirect buffers will add anything but confusion. I fixed the incorrect meaning of KEEP-VARIANTS, and I think the result is okay, definitely so for an internal utility function. Thanks.