From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Date: Sat, 28 Jan 2017 09:31:38 +0200 Message-ID: <83tw8jzllx.fsf@gnu.org> References: <871svzzcn4.fsf@gmail.com> <83lgu76nuf.fsf@gnu.org> <87vatac0a2.fsf@gmail.com> <83a8am6u6q.fsf@gnu.org> <87y3y6ezge.fsf@gmail.com> <8337gd7udo.fsf@gnu.org> <87o9z1n4o3.fsf@gmail.com> <83lgu252zc.fsf@gnu.org> <87o9yy26pg.fsf@gmail.com> <83fuka4yzj.fsf@gnu.org> <87vat65h3o.fsf@gmail.com> <87r33n3cgk.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1485588744 6126 195.159.176.226 (28 Jan 2017 07:32:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 07:32:24 +0000 (UTC) Cc: 25482@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 28 08:32:20 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXNUR-0008UU-7t for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2017 08:32:03 +0100 Original-Received: from localhost ([::1]:50272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXNUW-0004f3-LI for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2017 02:32:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXNUR-0004ex-BV for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 02:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXNUQ-0002FB-Fy for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 02:32:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXNUQ-0002F1-CY for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 02:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXNUQ-0002us-4J for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 02:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2017 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25482 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25482-submit@debbugs.gnu.org id=B25482.148558871711200 (code B ref 25482); Sat, 28 Jan 2017 07:32:02 +0000 Original-Received: (at 25482) by debbugs.gnu.org; 28 Jan 2017 07:31:57 +0000 Original-Received: from localhost ([127.0.0.1]:48760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXNUL-0002uZ-LA for submit@debbugs.gnu.org; Sat, 28 Jan 2017 02:31:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXNUK-0002uN-4D for 25482@debbugs.gnu.org; Sat, 28 Jan 2017 02:31:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXNUB-0002A7-MV for 25482@debbugs.gnu.org; Sat, 28 Jan 2017 02:31:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXNUB-0002A1-J6; Sat, 28 Jan 2017 02:31:47 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1435 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cXNUA-00045H-QJ; Sat, 28 Jan 2017 02:31:47 -0500 In-reply-to: <87r33n3cgk.fsf@gmail.com> (message from Thierry Volpiatto on Sat, 28 Jan 2017 07:50:19 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128707 Archived-At: > From: Thierry Volpiatto > Cc: 25482@debbugs.gnu.org > Date: Sat, 28 Jan 2017 07:50:19 +0100 > > Just to not leave this unfinished, here the last patch I did which > simplify code. > > - defcustom is simple (string or nil). > - No need to reevaluate defcustom at every time. > - setq is usable. > - splitting is now simple with all the text property dance removed. > - plain string is added to history instead of a crap string. Thanks, but I don't understand why you want to get rid of the display property. (I also object to calling the result of that "crap".) I'd rather we left the display property and its supporting code intact, and only moved the char-displayable-p call to the place where the string is used instead of having it in the defcustom, thus allowing customizations with setq. That should solve the real problems with the current code, leaving the style-related issues alone. I realize that you don't like that style, but I think we should respect style preferences of others and not change their code just because we would have written it differently.