unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 25482@debbugs.gnu.org
Subject: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil
Date: Sat, 28 Jan 2017 09:31:38 +0200	[thread overview]
Message-ID: <83tw8jzllx.fsf@gnu.org> (raw)
In-Reply-To: <87r33n3cgk.fsf@gmail.com> (message from Thierry Volpiatto on Sat, 28 Jan 2017 07:50:19 +0100)

> From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
> Cc: 25482@debbugs.gnu.org
> Date: Sat, 28 Jan 2017 07:50:19 +0100
> 
> Just to not leave this unfinished, here the last patch I did which
> simplify code.
> 
> - defcustom is simple (string or nil).
> - No need to reevaluate defcustom at every time.
> - setq is usable.
> - splitting is now simple with all the text property dance removed.
> - plain string is added to history instead of a crap string.

Thanks, but I don't understand why you want to get rid of the display
property.  (I also object to calling the result of that "crap".)  I'd
rather we left the display property and its supporting code intact,
and only moved the char-displayable-p call to the place where the
string is used instead of having it in the defcustom, thus allowing
customizations with setq.  That should solve the real problems with
the current code, leaving the style-related issues alone.  I realize
that you don't like that style, but I think we should respect style
preferences of others and not change their code just because we would
have written it differently.





  reply	other threads:[~2017-01-28  7:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  8:18 bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Thierry Volpiatto
2017-01-19 16:01 ` Eli Zaretskii
2017-01-20  5:54   ` Thierry Volpiatto
     [not found]   ` <87vatac0a2.fsf@gmail.com>
2017-01-20  5:42     ` bug#25482: Fwd: " Thierry Volpiatto
2017-01-20  7:56     ` Eli Zaretskii
2017-01-20 11:35       ` Thierry Volpiatto
2017-01-20 13:06         ` Eli Zaretskii
2017-01-20 15:16           ` Thierry Volpiatto
2017-01-22 19:06             ` Eli Zaretskii
2017-01-22 20:14               ` Thierry Volpiatto
2017-01-22 20:32                 ` Eli Zaretskii
2017-01-23  8:13                   ` Thierry Volpiatto
2017-01-28  6:50                     ` Thierry Volpiatto
2017-01-28  7:31                       ` Eli Zaretskii [this message]
2017-01-28 10:43                         ` Thierry Volpiatto
2017-01-28 11:01                           ` Eli Zaretskii
2017-01-28 11:23                             ` Thierry Volpiatto
2017-01-28 13:50                               ` Eli Zaretskii
2017-01-28 16:46                                 ` Thierry Volpiatto
     [not found]                                   ` <87k29ey93n.fsf@mail.linkov.net>
2017-01-29  3:42                                     ` Eli Zaretskii
2017-01-30  0:16                                       ` Juri Linkov
2017-02-13  0:37                                   ` Juri Linkov
2017-02-13  2:24                                     ` Glenn Morris
2017-02-13  3:04                                       ` Glenn Morris
2017-02-13  5:51                                     ` Eli Zaretskii
2017-02-14  0:04                                       ` Juri Linkov
2017-02-14  0:24                                         ` Drew Adams
2017-02-18 10:45                                           ` Eli Zaretskii
2017-02-13  5:53                                     ` Thierry Volpiatto
2017-02-16 20:43                                       ` Juri Linkov
2017-01-21 10:05           ` Thierry Volpiatto
2017-01-21 10:24             ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tw8jzllx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25482@debbugs.gnu.org \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).