From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26712: other-window/frame versions of find-library Date: Tue, 16 May 2017 22:36:36 +0300 Message-ID: <83tw4k61bv.fsf@gnu.org> References: <8897133a-0836-23a6-6bbe-aecc6ec8b7c8@aurox.ch> <9b566259-457c-faf2-10e1-42c084afccea@aurox.ch> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494963499 9425 195.159.176.226 (16 May 2017 19:38:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 May 2017 19:38:19 +0000 (UTC) Cc: 26712@debbugs.gnu.org, p.stephani2@gmail.com To: "Charles A. Roelli" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 16 21:38:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAiIJ-0002CX-Hb for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 May 2017 21:38:07 +0200 Original-Received: from localhost ([::1]:43664 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAiIP-0000Wn-3A for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 May 2017 15:38:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAiIJ-0000WX-AX for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 15:38:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAiIE-0006zt-9B for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 15:38:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46412) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dAiIE-0006zo-5R for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 15:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dAiID-0000FO-ST for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 15:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2017 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26712-submit@debbugs.gnu.org id=B26712.1494963423874 (code B ref 26712); Tue, 16 May 2017 19:38:01 +0000 Original-Received: (at 26712) by debbugs.gnu.org; 16 May 2017 19:37:03 +0000 Original-Received: from localhost ([127.0.0.1]:49089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAiHG-0000E2-7g for submit@debbugs.gnu.org; Tue, 16 May 2017 15:37:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAiHE-0000DU-IL for 26712@debbugs.gnu.org; Tue, 16 May 2017 15:37:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAiH4-0006KZ-9o for 26712@debbugs.gnu.org; Tue, 16 May 2017 15:36:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAiH4-0006KV-6P; Tue, 16 May 2017 15:36:50 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2159 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dAiH3-0000LI-1M; Tue, 16 May 2017 15:36:49 -0400 In-reply-to: (charles@aurox.ch) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132547 Archived-At: > From: "Charles A. Roelli" > Date: Tue, 16 May 2017 21:08:07 +0200 > > Attached is a revised patch with Philipp's other suggestions taken into > account. Thanks. A few comments: > +** Two new commands 'find-library-other-window' and > +'find-library-other-frame'. This is too terse. A few words regarding what these do would be much better. > +(defun find-library (library) > + "Find the Emacs Lisp source of the LIBRARY near point. This is confusing, IMO. Suggest to reword: Find the Emacs Lisp source of LIBRARY. Interactively, prompt for LIBRARY using the one at or near point as the default. > +(defun read-library-name () > + "Read and return a library name, defaulting to the one near point." I would explain here what constitutes a "library name", i.e. how does the function determine the library name at point. > +(defun find-library-other-window (library) > + "Find, in another window, the file defining LIBRARY at or near point. Any reason why the wording is different from that of find-library?