From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: alexanderm@web.de, 27427@debbugs.gnu.org
Subject: bug#27427: 26.0.50; Native line numbers lead to display error in company-mode popup
Date: Wed, 21 Jun 2017 21:15:37 +0300 [thread overview]
Message-ID: <83tw39urzq.fsf@gnu.org> (raw)
In-Reply-To: <6aa4616d-79f7-db1b-c048-076a9a48596f@yandex.ru> (message from Dmitry Gutov on Wed, 21 Jun 2017 16:04:58 +0300)
> Cc: alexanderm@web.de, 27427@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 21 Jun 2017 16:04:58 +0300
>
> On 6/21/17 5:40 AM, Eli Zaretskii wrote:
>
> >> When the position at bol is interpreted as "column 3", all lines of the
> >> rectangle are rendered starting with the fourth character of each line.
> >
> > So this is the root cause of the problem. Is there a reason not to
> > start rendering from the character whose posn-col-row is 3?
>
> How?
>
> Does that mean I'll have to call posn-at-point twice now? Once for
> point, and once for beginning-of-visual-line?
I guess so. I understand that now you call current-column or
something similar at BOL? Or do you just assume the column there is
zero?
> Even that won't solve all the rendering issues. In my testing, the first
> line of the popup is not at the same column as the rest of them.
> Probably because of the `line-prefix' property on the overlay which I
> explained in the previous email. And we can't stop putting it there
> because we don't have a better solution for the `line-prefix' text property.
What I had in mind is to come up with a solution that will work the
same with line-prefix specified in any way we support. Then you won't
need to put the line-prefix property on the company overlay.
Btw, can you remind me why we don't use pop-up menus for company
popups?
> Even so, I'm not sure this will be the end of it. Setting line-prefix
> doesn't seem to be an accurate model of the problem company popup has
> with native line numbering:
Could be. Can I seduce you to try the line-numbers branch? ;-)
next prev parent reply other threads:[~2017-06-21 18:15 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 16:50 bug#27427: 26.0.50; Native line numbers lead to display error in company-mode popup Alexander Miller
2017-06-19 17:08 ` Eli Zaretskii
[not found] ` <6b307502-53db-e92d-1050-3cf0132537cb@web.de>
2017-06-19 19:23 ` Eli Zaretskii
2017-06-19 19:53 ` Alexander Miller
2017-06-19 21:03 ` Dmitry Gutov
2017-06-20 15:04 ` Eli Zaretskii
2017-06-21 2:18 ` Dmitry Gutov
2017-06-21 2:40 ` Eli Zaretskii
2017-06-21 13:04 ` Dmitry Gutov
2017-06-21 15:51 ` Alexander Miller
2017-06-21 18:15 ` Eli Zaretskii [this message]
2017-06-21 22:41 ` Dmitry Gutov
2017-06-22 14:55 ` Eli Zaretskii
2017-06-22 23:17 ` Dmitry Gutov
2017-06-23 9:10 ` Eli Zaretskii
2017-06-23 23:26 ` Dmitry Gutov
2017-06-24 7:47 ` Eli Zaretskii
2017-06-24 17:28 ` Eli Zaretskii
2017-06-24 20:43 ` Dmitry Gutov
2017-06-25 13:51 ` Dmitry Gutov
2017-06-25 14:32 ` Eli Zaretskii
2017-06-25 14:36 ` Dmitry Gutov
2017-06-25 14:13 ` Eli Zaretskii
2017-06-25 14:46 ` Dmitry Gutov
2017-06-25 15:05 ` Eli Zaretskii
2017-06-25 16:35 ` Eli Zaretskii
2017-06-25 17:57 ` Eli Zaretskii
2017-06-25 22:56 ` Dmitry Gutov
2017-06-26 8:23 ` martin rudalics
2017-06-26 15:07 ` Eli Zaretskii
2017-06-27 7:06 ` martin rudalics
2017-06-27 14:48 ` Eli Zaretskii
2017-06-26 15:22 ` Eli Zaretskii
2017-06-26 15:28 ` Dmitry Gutov
2017-06-26 15:50 ` Eli Zaretskii
2017-06-26 17:12 ` Dmitry Gutov
2017-06-26 21:30 ` Johan Bockgård
2017-06-27 16:47 ` Eli Zaretskii
2017-07-13 23:04 ` Dmitry Gutov
2017-07-14 6:11 ` Eli Zaretskii
2017-07-14 6:24 ` Dmitry Gutov
2017-07-14 7:04 ` Eli Zaretskii
2017-07-15 17:38 ` Dmitry Gutov
2017-07-15 17:49 ` Eli Zaretskii
2017-06-25 14:31 ` Dmitry Gutov
2017-06-25 14:54 ` Eli Zaretskii
2017-06-25 15:25 ` Dmitry Gutov
2017-06-25 16:12 ` martin rudalics
2017-06-25 18:21 ` Eli Zaretskii
2017-06-25 15:59 ` martin rudalics
2017-06-25 16:24 ` Dmitry Gutov
2017-06-25 17:10 ` martin rudalics
2017-06-25 18:36 ` Eli Zaretskii
2017-06-25 18:51 ` Eli Zaretskii
2017-06-26 8:21 ` martin rudalics
2017-06-26 8:18 ` martin rudalics
2017-06-25 18:24 ` Eli Zaretskii
2017-06-26 7:15 ` martin rudalics
2017-06-26 8:18 ` martin rudalics
2017-06-26 12:07 ` Dmitry Gutov
2017-06-26 15:05 ` Eli Zaretskii
2017-06-27 7:06 ` martin rudalics
2017-06-27 14:48 ` Eli Zaretskii
2017-06-27 15:27 ` martin rudalics
2017-06-27 16:27 ` Eli Zaretskii
2017-06-28 8:45 ` martin rudalics
2017-06-28 16:48 ` Eli Zaretskii
2017-06-28 18:35 ` martin rudalics
2017-06-28 18:56 ` Eli Zaretskii
2017-06-29 7:17 ` martin rudalics
2017-06-29 16:29 ` Eli Zaretskii
2017-06-30 8:27 ` martin rudalics
2017-06-30 9:33 ` Eli Zaretskii
2017-07-01 10:31 ` martin rudalics
2017-07-01 11:59 ` Eli Zaretskii
2017-07-01 13:22 ` martin rudalics
2017-07-01 13:33 ` Eli Zaretskii
2017-07-01 15:20 ` martin rudalics
2017-07-01 15:41 ` Eli Zaretskii
2017-07-02 7:54 ` martin rudalics
2017-07-02 14:10 ` Eli Zaretskii
2017-07-02 14:45 ` Dmitry Gutov
2017-07-02 15:18 ` Eli Zaretskii
2017-07-03 0:22 ` Dmitry Gutov
2017-07-03 2:29 ` Eli Zaretskii
2017-07-06 7:08 ` martin rudalics
2017-07-06 13:06 ` Dmitry Gutov
2017-07-07 6:52 ` martin rudalics
2017-07-06 7:08 ` martin rudalics
2017-07-06 15:21 ` Eli Zaretskii
2017-07-07 6:52 ` martin rudalics
2017-06-29 1:34 ` Dmitry Gutov
2017-06-29 16:20 ` Eli Zaretskii
2017-06-29 17:55 ` Dmitry Gutov
2017-06-25 19:00 ` Eli Zaretskii
2017-06-26 8:21 ` martin rudalics
2017-06-26 15:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tw39urzq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27427@debbugs.gnu.org \
--cc=alexanderm@web.de \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).