From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28302: 26.0.50; [PATCH] Make ucs-names a hash table Date: Thu, 31 Aug 2017 17:00:19 +0300 Message-ID: <83tw0n25xo.fsf@gnu.org> References: <87r2vsqqeo.fsf@holos> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1504188144 9267 195.159.176.226 (31 Aug 2017 14:02:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 31 Aug 2017 14:02:24 +0000 (UTC) Cc: 28302@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 31 16:02:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnQ2s-0001pS-Ic for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Aug 2017 16:02:10 +0200 Original-Received: from localhost ([::1]:55954 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnQ2z-0006M6-Nm for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Aug 2017 10:02:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnQ2s-0006Ko-Bb for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 10:02:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnQ2k-0000Hn-QB for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 10:02:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnQ2k-0000Hi-MP for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 10:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dnQ2k-0003qm-Bf for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 10:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2017 14:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28302-submit@debbugs.gnu.org id=B28302.150418806414722 (code B ref 28302); Thu, 31 Aug 2017 14:02:02 +0000 Original-Received: (at 28302) by debbugs.gnu.org; 31 Aug 2017 14:01:04 +0000 Original-Received: from localhost ([127.0.0.1]:37646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnQ1o-0003pO-Ei for submit@debbugs.gnu.org; Thu, 31 Aug 2017 10:01:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnQ1l-0003on-Sx for 28302@debbugs.gnu.org; Thu, 31 Aug 2017 10:01:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnQ1Z-0008BL-0X for 28302@debbugs.gnu.org; Thu, 31 Aug 2017 10:00:56 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnQ1Y-0008Ay-O6; Thu, 31 Aug 2017 10:00:48 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3081 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dnQ1W-00009t-LC; Thu, 31 Aug 2017 10:00:48 -0400 In-reply-to: <87r2vsqqeo.fsf@holos> (message from Mark Oteiza on Thu, 31 Aug 2017 01:04:15 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136403 Archived-At: > From: Mark Oteiza > Date: Thu, 31 Aug 2017 01:04:15 -0400 > > I seem to remember there having been complaints about ucs-names preview > being slow. I was curious about how much of that time was spent > assoc'ing every element of a roughly n = 42k element long alist, and so > tried making it a hash table instead. The result is a drastic speedup > of C-x 8 RET TAB, presumably this makes the operation O(n) vs O(n^2). Thanks, this is a very good change. Please make sure (if you haven't already) that it survives bootstrap. Also, there are other places which assume that ucs-names is an alist, so I guess this is not the full final patch? And this should be mentioned in NEWS under incompatible Lisp changes, as ucs-names debuted in Emacs 23.1, and there could be some uses of it outside Emacs proper.