From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: andrewjmoreton@gmail.com, winkler@gnu.org, 28824@debbugs.gnu.org
Subject: bug#28824: 26.0.90; display of pbm images broken?
Date: Mon, 16 Oct 2017 18:11:58 +0300 [thread overview]
Message-ID: <83tvyzf7pd.fsf@gnu.org> (raw)
In-Reply-To: <6c4a985c-b0a1-93a4-8c3b-36f7c2f5721c@cs.ucla.edu> (message from Paul Eggert on Mon, 16 Oct 2017 01:30:07 -0700)
> Cc: 28824-done@debbugs.gnu.org, Roland Winkler <winkler@gnu.org>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 16 Oct 2017 01:30:07 -0700
>
> > Looks like going back to unsigned should be cleaner, but I'd like to
> > hear what Paul thinks.
>
> Andy's fixes look good to me. Going back to unsigned would result in several
> pointer casts that are more dangerous than converting to unsigned. They can be
> further improved by encapsulating this stuff into a function, and I installed
> the attached (the second one is Andy's other fix, which I installed in his name).
>
> I looked for related bugs in image.c (i.e., caused by my earlier patch) and did
> not find any.
OK, thanks.
next prev parent reply other threads:[~2017-10-16 15:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 2:10 bug#28824: 26.0.90; display of pbm images broken? Roland Winkler
2017-10-14 7:01 ` Eli Zaretskii
2017-10-14 15:01 ` Andy Moreton
2017-10-14 15:31 ` Eli Zaretskii
2017-10-14 18:16 ` Andy Moreton
2017-10-14 19:03 ` Andy Moreton
2017-10-14 19:16 ` Eli Zaretskii
2017-10-14 19:50 ` Andy Moreton
2017-10-14 20:15 ` Andy Moreton
2017-10-14 19:14 ` Eli Zaretskii
2017-10-14 21:52 ` Roland Winkler
2017-10-15 17:42 ` Andy Moreton
2017-10-15 18:49 ` Eli Zaretskii
2017-10-16 8:30 ` Paul Eggert
2017-10-16 15:11 ` Eli Zaretskii [this message]
2017-10-16 15:22 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvyzf7pd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28824@debbugs.gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).