unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Łukasz Jędrzejewski" <jedrzejewskiluk@gmail.com>
Cc: 29045-done@debbugs.gnu.org
Subject: bug#29045: [PATCH] auth-source-pass: Extract user from host when searching for entries
Date: Sat, 04 Nov 2017 12:28:58 +0200	[thread overview]
Message-ID: <83tvyatk0l.fsf@gnu.org> (raw)
In-Reply-To: <CANaFO73drrsh0rGJ6o3Xn5DGBr_0ps9AU8J59W2Qjpv-jYsg8g@mail.gmail.com> (jedrzejewskiluk@gmail.com)

> From: Łukasz Jędrzejewski
> 	<jedrzejewskiluk@gmail.com>
> Date: Sat, 28 Oct 2017 20:53:01 +0200
> 
> I have recently contributed to auth-password-store package created by
> Damien Cassou [1] and the proposed change has been successfully merged.
> After that Damien suggested me to propose the same change to the Emacs
> repository itself since the auth-password-store has been integrated inside
> the core.
> 
> Regarding the attached patch: When auth-source-search is asked to find an
> entry only by :host key; e.g. login@hostname.com and having an entry
> hostname.com/login located in .password-store nothing is found. With this
> patch, such an entry would be found. I have added a test case to document
> the change.
> 
> What do you think?

Thanks, I pushed your changes to the master branch.

Please note that your mailer wraps long lines, which makes the patches
unsuitable for applying.  Please in the future send patches as
attachments.

I would also encourage you to start your legal paperwork for assigning
copyright of your changes to the FSF, so that we could accept your
future contributions without limitations.





      reply	other threads:[~2017-11-04 10:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-28 18:53 bug#29045: [PATCH] auth-source-pass: Extract user from host when searching for entries Łukasz Jędrzejewski
2017-11-04 10:28 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tvyatk0l.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=29045-done@debbugs.gnu.org \
    --cc=jedrzejewskiluk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).