From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33669: 26.1; Buffer-menu-mode bad UX Date: Sat, 08 Dec 2018 13:07:42 +0200 Message-ID: <83tvjo46pt.fsf@gnu.org> References: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1544267228 4966 195.159.176.226 (8 Dec 2018 11:07:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Dec 2018 11:07:08 +0000 (UTC) Cc: 33669@debbugs.gnu.org To: Devon Sean McCullough Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 08 12:07:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVaRp-00016x-NJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Dec 2018 12:07:01 +0100 Original-Received: from localhost ([::1]:50313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVaTw-0001BF-94 for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Dec 2018 06:09:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVaTq-0001Ay-2c for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 06:09:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVaTm-00012T-Ul for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 06:09:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33432) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gVaTm-00012L-R4 for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 06:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gVaTm-0002iB-HP for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 06:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Dec 2018 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33669 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33669-submit@debbugs.gnu.org id=B33669.154426729310347 (code B ref 33669); Sat, 08 Dec 2018 11:09:02 +0000 Original-Received: (at 33669) by debbugs.gnu.org; 8 Dec 2018 11:08:13 +0000 Original-Received: from localhost ([127.0.0.1]:37690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVaSy-0002go-TC for submit@debbugs.gnu.org; Sat, 08 Dec 2018 06:08:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVaSx-0002gc-CA for 33669@debbugs.gnu.org; Sat, 08 Dec 2018 06:08:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVaSo-0008UG-TW for 33669@debbugs.gnu.org; Sat, 08 Dec 2018 06:08:06 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVaSo-0008U4-Q7; Sat, 08 Dec 2018 06:08:02 -0500 Original-Received: from [176.228.60.248] (port=2950 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gVaSm-0003Pe-Jk; Sat, 08 Dec 2018 06:08:02 -0500 In-reply-to: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> (message from Devon Sean McCullough on Sat, 8 Dec 2018 10:06:48 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153218 Archived-At: > From: Devon Sean McCullough > Date: Sat, 8 Dec 2018 10:06:48 +0800 > > When Buffer-menu-execute asks > > Buffer foo modified; kill anyway? (yes or no) > > and the reply is no, > that line is removed anyway, deceiving the user > by making the buffer menu incorrect. > > The user will promptly seek out such buffers — but they disappeared, > giving the distressing wrong impression that they were killed anyway. Thanks for reporting this. Does the patch below give good results? diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index bc1288a..95746b3 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -476,9 +476,10 @@ Buffer-menu-execute (tabulated-list-set-col 2 " " t)) (error (warn "Error saving %s" buffer)))) (if delete - (unless (eq buffer (current-buffer)) - (kill-buffer buffer) - (tabulated-list-delete-entry)) + (if (and (not (eq buffer (current-buffer))) + (kill-buffer buffer)) + (tabulated-list-delete-entry) + (forward-line 1)) (forward-line 1))))))))) (defun Buffer-menu-select ()