unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Werner LEMBERG <wl@gnu.org>
Cc: 33885@debbugs.gnu.org
Subject: bug#33885: 27.0.50; PUA character makes emacs crash
Date: Fri, 28 Dec 2018 17:33:07 +0200	[thread overview]
Message-ID: <83tvix64zw.fsf@gnu.org> (raw)
In-Reply-To: <20181228.155850.556290055640666168.wl@gnu.org> (message from Werner LEMBERG on Fri, 28 Dec 2018 15:58:50 +0100 (CET))

> Date: Fri, 28 Dec 2018 15:58:50 +0100 (CET)
> Cc: 33885@debbugs.gnu.org
> From: Werner LEMBERG <wl@gnu.org>
> 
> OK.  `XftFontOpenPattern' returns the following data for `Cardo':
> 
> (gdb) p *xftfont
> $12 = {
>   ascent = 16, 
>   descent = -5, 
>   height = 6, 
>   max_advance_width = 91, 
>   charset = 0x7fffe23d52d8, 
>   pattern = 0x1f01050
> }
> 
> This is problematic, since it only reflects the Apple values for
> ascent and descent (i.e., the data in the font's `hhea' table).  To
> solve the issue, there are two possible solutions IMHO.
> 
> (1) Simply accept whatever `XftFontOpenPattern' returns, including
>     negative values for `descent' – actually, such font might exist:
>     for example, consider a special font that only contains dashes of
>     different length.

I don't think this is a good idea.

> (2) Improve the heuristics to get sensible global ascent and descent
>     values of a font.  In particular, use the FreeType library to
>     access a TrueType's or OpenType's `OS/2' table and compare its
>     vertical metrics values with the `hhea' data to eliminate bugs in
>     the font – sign problems with `descent' do happen especially in
>     older fonts that were either designed for Apple or for Windows,
>     and the fields for the `other' OS were filled out arbitrarily,
>     more or less.

I'd appreciate more details on how this could be done.  I'm no expert
on fonts nor on FreeType, and last I checked we have no one else.

Thanks.





  reply	other threads:[~2018-12-28 15:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-27  8:54 bug#33885: 27.0.50; PUA character makes emacs crash Werner LEMBERG
2018-12-27 10:36 ` Eli Zaretskii
2018-12-27 11:33   ` Eli Zaretskii
2018-12-28  8:33   ` Werner LEMBERG
2018-12-28  9:16     ` Eli Zaretskii
2018-12-28 12:38       ` Werner LEMBERG
2018-12-28 13:30         ` Eli Zaretskii
2018-12-28 14:58           ` Werner LEMBERG
2018-12-28 15:33             ` Eli Zaretskii [this message]
2018-12-28 17:03               ` Werner LEMBERG
2018-12-28 17:06                 ` Werner LEMBERG
2018-12-28 19:15                 ` Eli Zaretskii
2022-02-12  8:42 ` Lars Ingebrigtsen
2022-02-12  8:57   ` Eli Zaretskii
2022-03-12 22:43     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tvix64zw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33885@debbugs.gnu.org \
    --cc=wl@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).