From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36447: 27.0.50; New "Unknown keyword" errors Date: Fri, 05 Jul 2019 11:25:33 +0300 Message-ID: <83tvc0anwi.fsf@gnu.org> References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="77153"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 05 10:27:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjJZ6-000Jx8-7D for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 10:27:32 +0200 Original-Received: from localhost ([::1]:50464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjJZ5-0001IT-8l for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 04:27:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55613) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjJXf-000882-Rx for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 04:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjJXe-0000Ax-Ds for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 04:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjJXe-0000Ah-AW for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 04:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjJXe-0004KV-4m for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 04:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2019 08:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36447 X-GNU-PR-Package: emacs Original-Received: via spool by 36447-submit@debbugs.gnu.org id=B36447.156231515216628 (code B ref 36447); Fri, 05 Jul 2019 08:26:02 +0000 Original-Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 08:25:52 +0000 Original-Received: from localhost ([127.0.0.1]:52332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJXT-0004K8-Uz for submit@debbugs.gnu.org; Fri, 05 Jul 2019 04:25:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJXR-0004Ju-Ts for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 04:25:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjJXM-0008N4-DT; Fri, 05 Jul 2019 04:25:44 -0400 Original-Received: from [176.228.60.248] (port=1398 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjJXI-0000xp-Gh; Fri, 05 Jul 2019 04:25:44 -0400 In-reply-to: (message from Pip Cet on Fri, 5 Jul 2019 08:12:07 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162109 Archived-At: > From: Pip Cet > Date: Fri, 5 Jul 2019 08:12:07 +0000 > Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > > On Fri, Jul 5, 2019 at 7:50 AM Eli Zaretskii wrote: > > > rwatch -l *(long *)&XHASH_TABLE(obj)->index > > > watch -l *(long *)XHASH_TABLE(obj)->index > > > > I think this is the same as > > > > awatch -l *(long *)XHASH_TABLE(obj)->index > > Thanks for checking! What I actually meant was > awatch -l *(long *)&XHASH_TABLE(obj)->index But then why do you need the rwatch as well? awatch breaks both on read accesses and on write accesses. > With revision 44f199648b0c986a0ac7608f4e9d803c619ae2d6, I can > reproduce this problem locally, and I can confirm it's as I thought: > > y-or-no-p and custom-handle-keyword both generate 7-element hash > tables. They share a ->next vector. Both try to rehash the hash table, > and since there are non-builtin symbols in there, the new hash > collision chains should differ, but can't, since they share a vector. > > I don't think we can sensibly add tests for this bug, but the fix I > posted earlier still seems valid to me. Sorry, I'm not tracking this part of the discussion, as it lost me long ago.