From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36598: 26.1; (error "=?UTF-8?Q?=E2=80=98/tmp/emacs1000=E2=80=99?= is not a safe directory because it is a symlink") Date: Thu, 18 Jul 2019 09:27:20 +0300 Message-ID: <83tvbjyi0n.fsf@gnu.org> References: <87muhkr79y.fsf@silk.nichework.com> <87k1cmwnu6.fsf@mouse.gnus.org> <44a502116d2c0568d120b7328913b26a@russet.org.uk> <20a62c04ad67dc64665b32d7a31cfe8b@russet.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="146404"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, 36598@debbugs.gnu.org, mah@everybody.org, phillip.lord@russet.org.uk To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 18 08:28:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hnztf-000y59-IM for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 08:28:07 +0200 Original-Received: from localhost ([::1]:34790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnzte-0000N6-0u for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 02:28:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47598) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnztb-0000N0-F5 for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 02:28:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnzta-00031R-Fb for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 02:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44487) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hnzta-00030y-BE for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 02:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hnzta-0006ki-4u for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 02:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 06:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36598 X-GNU-PR-Package: emacs Original-Received: via spool by 36598-submit@debbugs.gnu.org id=B36598.156343125925928 (code B ref 36598); Thu, 18 Jul 2019 06:28:02 +0000 Original-Received: (at 36598) by debbugs.gnu.org; 18 Jul 2019 06:27:39 +0000 Original-Received: from localhost ([127.0.0.1]:53308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnztD-0006k8-Ds for submit@debbugs.gnu.org; Thu, 18 Jul 2019 02:27:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnztA-0006ju-Di for 36598@debbugs.gnu.org; Thu, 18 Jul 2019 02:27:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hnzt3-0002im-In; Thu, 18 Jul 2019 02:27:29 -0400 Original-Received: from [176.228.60.248] (port=1119 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hnzt2-0002sk-C9; Thu, 18 Jul 2019 02:27:29 -0400 In-reply-to: (message from Stefan Monnier on Mon, 15 Jul 2019 09:04:22 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173310 > From: Stefan Monnier > Date: Mon, 15 Jul 2019 09:04:22 -0400 > Cc: Lars Ingebrigtsen , 36598@debbugs.gnu.org, > mah@everybody.org > > >> Commit b663c837249 (in May) which says "Cosmetic changes" is the one > >> that introduced this code? > >> > >> (let ((olddir (or (getenv "TMPDIR") "/tmp"))) > >> (when (and (equal dir (format "%s/emacs" (getenv > >> "XDG_RUNTIME_DIR"))) > >> (file-writable-p olddir)) > >> (let ((link (format "%s/emacs%d" olddir (user-uid)))) > >> (unless (file-directory-p link) > >> ;; We're using the new location, so try and setup a symlink > >> from > >> ;; the old location, in case we want to use an > >> old emacsclient. > >> ;; FIXME: Check that it's safe to use! > >> (make-symbolic-link dir link t))))) > >> > >> And instead of making things work with an old emacsclient, it breaks the > >> Emacs 26 emacsclient? > > > > Nearly. I think it breaks emacs-26 not the emacsclient. I haven't check the > > emacsclient code, but I guess Stefan was > > aiming for the situation when someone is using (say) emacsclient-26 with > > emacs-27. > > Indeed (it's Debian/s /usr/bin/emacsclient accessing my hand-built > Emacs-27 server). > > >> Stefan, was this checked in by mistake? > > Definitely, If this mistake adversely affects the release branch, please revert that commit. We will have RC1 soon. Thanks.