From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Date: Wed, 07 Aug 2019 17:38:30 +0300 Message-ID: <83tvatavmh.fsf@gnu.org> References: <83wofwexkr.fsf@gnu.org> <20190805152747.4vyzejqoiy33l4ou@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="229938"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 07 16:39:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hvN5z-000xeZ-LT for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 16:39:19 +0200 Original-Received: from localhost ([::1]:41954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvN5y-0007yF-Nu for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 10:39:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42321) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvN5k-0007bh-73 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 10:39:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvN5i-00008M-UA for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 10:39:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58607) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvN5i-00008G-R1 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 10:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvN5i-0003h6-O5 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 10:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2019 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36858 X-GNU-PR-Package: emacs Original-Received: via spool by 36858-submit@debbugs.gnu.org id=B36858.156518872814164 (code B ref 36858); Wed, 07 Aug 2019 14:39:02 +0000 Original-Received: (at 36858) by debbugs.gnu.org; 7 Aug 2019 14:38:48 +0000 Original-Received: from localhost ([127.0.0.1]:39193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvN5U-0003gO-8q for submit@debbugs.gnu.org; Wed, 07 Aug 2019 10:38:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvN5S-0003gB-Sd for 36858@debbugs.gnu.org; Wed, 07 Aug 2019 10:38:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hvN5N-0008QE-MZ; Wed, 07 Aug 2019 10:38:41 -0400 Original-Received: from [176.228.60.248] (port=2149 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hvN5N-0003Nr-1C; Wed, 07 Aug 2019 10:38:41 -0400 In-reply-to: <20190805152747.4vyzejqoiy33l4ou@Ergus> (message from Ergus on Mon, 5 Aug 2019 17:27:47 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164714 Archived-At: > Date: Mon, 5 Aug 2019 17:27:47 +0200 > From: Ergus > Cc: 36858@debbugs.gnu.org, Davor Rotim > > 1) The condition ends_at_zv_p didn't work as expected, I don't know If > this is an issue somewhere else, but at least in my tests, the condition > was always false. (for all the lines implied before and after ZV, where > there was company window or not) > > So the filter condition I am using now is: > > IT_CHARPOS (*it) < ZV > > which seems to work fine. > > 2) There is a corner case because the indicator is never generated for > the latest line in the buffer. So a \n is required always at the end of > the buffer if there is text, which for me is fine (unix format), but I > don't know if I should correct that, should I? Unix format has nothing to do with this, as in a buffer we always have only \n characters at end of line. But notr having the indicator show in the last line of a buffer that doesn't end in a newline is unfortunate. Which is why I suggested to test the ends_at_zv_p flag. What exactly didn't work with it? Can you show me a test case where the glyph rows past ZV don't have this flag set? Maybe you should test the enabled_p flag as well? > In terminal emacs, in the original emacs-26 code, in the function: > extend_face_to_end_of_line the code was: > > ``` > face = FACE_FROM_ID (f, (it->face_before_selective_p > ? it->saved_face_id > : it->face_id)); > (...) > > if (it->glyph_row->ends_at_zv_p) > it->face_id = default_face->id; > else > it->face_id = face->id; > PRODUCE_GLYPHS (it); > > while (it->current_x <= it->last_visible_x) > PRODUCE_GLYPHS (it); > ``` > > So the rest of the line was filled with the last face, (so this issue was > already there since then, because the rest of the line is filled with an > underlined face) > > I can change the code to fill the rest of the line with a new merged > face (as I do for graphical emacs), but I think that this fix is > unrelated with dfci, so maybe someone else must give a look before to > prevent me breaking anything. This is a more general issue, and I will respond to your question on emacs-devel. Thanks.