From: Eli Zaretskii <eliz@gnu.org>
To: mituharu@math.s.chiba-u.ac.jp
Cc: 37153@debbugs.gnu.org, eggert@cs.ucla.edu, winkler@gnu.org
Subject: bug#37153: 26.1; some png images scrambled
Date: Sat, 24 Aug 2019 13:17:31 +0300 [thread overview]
Message-ID: <83tva6j29w.fsf@gnu.org> (raw)
In-Reply-To: <9c4c68ebe20cbcc44763be8e72bd25eb.squirrel@weber.math.s.chiba-u.ac.jp> (mituharu@math.s.chiba-u.ac.jp)
> Date: Sat, 24 Aug 2019 18:01:46 +0900
> From: mituharu@math.s.chiba-u.ac.jp
> Cc: 37153@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>
>
> I suspect there is a longstanding typo (or thinko) in PNG
> transparency handling code.
>
> YAMAMOTO Mitsuharu
> mituharu@math.s.chiba-u.ac.jp
>
> diff --git a/src/image.c b/src/image.c
> index 81d8cb4e2b2..819e058f7e1 100644
> --- a/src/image.c
> +++ b/src/image.c
> @@ -6680,7 +6680,7 @@ png_load_body (struct frame *f, struct image *img,
> struct png_load_context *c)
> /* Create an image and pixmap serving as mask if the PNG image
> contains an alpha channel. */
> if (channels == 4
> - && !transparent_p
> + && transparent_p
> && !image_create_x_image_and_pixmap (f, img, width, height, 1,
> &mask_img, 1))
> {
>
That didn't change anything in how I see the image in question, FWIW.
next prev parent reply other threads:[~2019-08-24 10:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 4:49 bug#37153: 26.1; some png images scrambled Roland Winkler
2019-08-23 8:47 ` Eli Zaretskii
2019-08-23 11:39 ` Roland Winkler
2019-08-23 12:22 ` Eli Zaretskii
2019-08-23 15:07 ` Roland Winkler
2019-08-23 15:34 ` Eli Zaretskii
2019-08-23 19:37 ` Paul Eggert
2019-08-23 20:11 ` Eli Zaretskii
2019-08-23 20:33 ` Paul Eggert
2019-08-24 5:51 ` Eli Zaretskii
2019-08-24 3:17 ` Roland Winkler
2019-08-24 3:39 ` Paul Eggert
2019-08-24 4:19 ` Roland Winkler
2019-08-24 6:26 ` Eli Zaretskii
2019-08-24 6:22 ` Eli Zaretskii
2019-08-24 9:01 ` mituharu
2019-08-24 10:17 ` Eli Zaretskii [this message]
2019-08-25 4:19 ` YAMAMOTO Mitsuharu
2019-08-25 7:24 ` Eli Zaretskii
2019-08-25 4:52 ` Roland Winkler
2019-08-25 6:58 ` YAMAMOTO Mitsuharu
2019-08-25 12:19 ` Roland Winkler
2019-08-25 18:38 ` Paul Eggert
2019-08-25 18:56 ` Eli Zaretskii
2019-08-25 23:02 ` YAMAMOTO Mitsuharu
2019-08-25 23:06 ` YAMAMOTO Mitsuharu
2019-08-25 23:39 ` Paul Eggert
2019-09-24 16:23 ` Lars Ingebrigtsen
2019-09-24 17:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tva6j29w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37153@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=mituharu@math.s.chiba-u.ac.jp \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).