From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36670: 27.0.50; Wishlist: describe-face should use the new help-buffer infrastructure Date: Sat, 21 Sep 2019 11:22:33 +0300 Message-ID: <83tv96qcs6.fsf@gnu.org> References: <87d0ibcm0z.fsf@mouse.gnus.org> <87ef0a60uu.fsf@gnus.org> <831rwarw0g.fsf@gnu.org> <87blve2ivg.fsf@gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="194656"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36670@debbugs.gnu.org To: Lars Ingebrigtsen , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 21 10:23:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBafm-000oUt-Qe for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Sep 2019 10:23:18 +0200 Original-Received: from localhost ([::1]:40132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBafj-0003iJ-ST for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Sep 2019 04:23:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35709) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBafX-0003gt-A5 for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 04:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBafW-0008Cy-7N for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 04:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBafW-0008CU-3Y for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 04:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBafV-0007hK-UP for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 04:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2019 08:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 36670-submit@debbugs.gnu.org id=B36670.156905415229533 (code B ref 36670); Sat, 21 Sep 2019 08:23:01 +0000 Original-Received: (at 36670) by debbugs.gnu.org; 21 Sep 2019 08:22:32 +0000 Original-Received: from localhost ([127.0.0.1]:59058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBaf2-0007gH-HT for submit@debbugs.gnu.org; Sat, 21 Sep 2019 04:22:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBaf0-0007g5-PL for 36670@debbugs.gnu.org; Sat, 21 Sep 2019 04:22:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iBaev-0007hI-Gi; Sat, 21 Sep 2019 04:22:25 -0400 Original-Received: from [176.228.60.248] (port=4474 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iBaeu-0004f1-Tq; Sat, 21 Sep 2019 04:22:25 -0400 In-reply-to: <87blve2ivg.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 21 Sep 2019 09:44:51 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166847 Archived-At: > From: Lars Ingebrigtsen > Cc: 36670@debbugs.gnu.org > Date: Sat, 21 Sep 2019 09:44:51 +0200 > > Eli Zaretskii writes: > > > What does this mean in practice? I see nothing about this in NEWS or > > in the manuals, which makes me wonder how is this "more flexible". I > > guess there were some discussions, but neither the log message nor the > > bug discussion mentions any other sources of information. Could you > > please point to those discussions, or fill the void by explaining what > > additional flexibility do we gain? This is for future forensics, if > > for nothing else. > > I don't think this was discussed much at all -- it relates to the > rewrite Stefan did in April, and he mentioned (in a comment to a fix to > `describe-face') that that function should be rewritten in a similar way. > > commit 896e5802160c2797e689a7565599ebb1bd171295 > Author: Stefan Monnier > Date: Fri Apr 12 12:37:00 2019 -0400 > > * lisp/help-fns.el (help-fns-describe-variable-functions): New hook > > (help-fns--compiler-macro, help-fns--parent-mode, help-fns--obsolete) > (help-fns--interactive-only): Indent output by 2 spaces. > (help-fns--side-effects): New function extracted from > describe-function-1. > (help-fns-describe-function-functions): Use it. > (help-fns--first-release, help-fns--mention-first-release): New functions. > (help-fns-function-description-header): Keymaps and macros can't > be interactive. > (help-fns--ensure-empty-line): New function. > (describe-function-1): Use it. > (help-fns--var-safe-local, help-fns--var-risky) > (help-fns--var-ignored-local, help-fns--var-file-local) > (help-fns--var-watchpoints, help-fns--var-obsolete) > (help-fns--var-alias, help-fns--var-bufferlocal): New functions, > extacted from describe-variable. > (describe-variable): Run help-fns-describe-variable-functions instead. So we are making changes without a good understanding what kind of flexibility it gains us?