From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 36670@debbugs.gnu.org
Subject: bug#36670: 27.0.50; Wishlist: describe-face should use the new help-buffer infrastructure
Date: Sat, 21 Sep 2019 11:22:33 +0300 [thread overview]
Message-ID: <83tv96qcs6.fsf@gnu.org> (raw)
In-Reply-To: <87blve2ivg.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 21 Sep 2019 09:44:51 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 36670@debbugs.gnu.org
> Date: Sat, 21 Sep 2019 09:44:51 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > What does this mean in practice? I see nothing about this in NEWS or
> > in the manuals, which makes me wonder how is this "more flexible". I
> > guess there were some discussions, but neither the log message nor the
> > bug discussion mentions any other sources of information. Could you
> > please point to those discussions, or fill the void by explaining what
> > additional flexibility do we gain? This is for future forensics, if
> > for nothing else.
>
> I don't think this was discussed much at all -- it relates to the
> rewrite Stefan did in April, and he mentioned (in a comment to a fix to
> `describe-face') that that function should be rewritten in a similar way.
>
> commit 896e5802160c2797e689a7565599ebb1bd171295
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri Apr 12 12:37:00 2019 -0400
>
> * lisp/help-fns.el (help-fns-describe-variable-functions): New hook
>
> (help-fns--compiler-macro, help-fns--parent-mode, help-fns--obsolete)
> (help-fns--interactive-only): Indent output by 2 spaces.
> (help-fns--side-effects): New function extracted from
> describe-function-1.
> (help-fns-describe-function-functions): Use it.
> (help-fns--first-release, help-fns--mention-first-release): New functions.
> (help-fns-function-description-header): Keymaps and macros can't
> be interactive.
> (help-fns--ensure-empty-line): New function.
> (describe-function-1): Use it.
> (help-fns--var-safe-local, help-fns--var-risky)
> (help-fns--var-ignored-local, help-fns--var-file-local)
> (help-fns--var-watchpoints, help-fns--var-obsolete)
> (help-fns--var-alias, help-fns--var-bufferlocal): New functions,
> extacted from describe-variable.
> (describe-variable): Run help-fns-describe-variable-functions instead.
So we are making changes without a good understanding what kind of
flexibility it gains us?
next prev parent reply other threads:[~2019-09-21 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 16:14 bug#36670: 27.0.50; Wishlist: describe-face should use the new help-buffer infrastructure Lars Ingebrigtsen
2019-09-20 22:48 ` Lars Ingebrigtsen
2019-09-21 6:41 ` Eli Zaretskii
2019-09-21 7:44 ` Lars Ingebrigtsen
2019-09-21 8:22 ` Eli Zaretskii [this message]
2019-09-21 8:38 ` Lars Ingebrigtsen
2019-09-21 9:05 ` Eli Zaretskii
2019-09-21 9:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tv96qcs6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36670@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).