From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sat, 16 Nov 2019 10:09:54 +0200 Message-ID: <83tv746y3x.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <83blte7kvc.fsf@gnu.org> <838soi5xm1.fsf@gnu.org> <838soh4l4n.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="119094"; mail-complaints-to="usenet@blaine.gmane.org" Cc: jonas@bernoul.li, 37774@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 16 09:11:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVtAm-000Urq-7C for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 09:11:12 +0100 Original-Received: from localhost ([::1]:46796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVtAk-0005k1-GM for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 03:11:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53609) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVtAd-0005je-V5 for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 03:11:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVtAc-0001k1-S2 for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 03:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57079) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVtAc-0001jx-P3 for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 03:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVtAc-00085K-G9 for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 03:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2019 08:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157389180531006 (code B ref 37774); Sat, 16 Nov 2019 08:11:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Nov 2019 08:10:05 +0000 Original-Received: from localhost ([127.0.0.1]:37667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVt9g-000842-Jy for submit@debbugs.gnu.org; Sat, 16 Nov 2019 03:10:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVt9e-00083T-BG for 37774@debbugs.gnu.org; Sat, 16 Nov 2019 03:10:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVt9Z-0001Li-0v; Sat, 16 Nov 2019 03:09:57 -0500 Original-Received: from [176.228.60.248] (port=3800 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVt9Y-00071D-I8; Sat, 16 Nov 2019 03:09:56 -0500 In-reply-to: (message from Dmitry Gutov on Sat, 16 Nov 2019 01:50:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171702 Archived-At: > Cc: jonas@bernoul.li, 37774@debbugs.gnu.org > From: Dmitry Gutov > Date: Sat, 16 Nov 2019 01:50:22 +0200 > > >>> If the backward compatibility (or, rather, transparent DWIM-ish > >>> operation) is the overriding consideration, then you are actually > >>> saying that any face attribute we will introduce in the future will > >>> have to be treated the same? > >> > >> I don't know what attributes we will introduce, and whether the default > >> values will be a departure from the previous behavior like this one is. > > > > It doesn't matter if the default face definition uses that attribute, > > does it? > > Well, it kind of does. At least, if the default value of the new > attribute is in line with the previous behavior, most faces won't have > to change. I was talking about the case where the defface we have for that face DOES use the new attribute. In that case, the default value of the attribute doesn't matter, since the defface uses some specific value, and that will always be a non-default value. IOW, whenever we introduce a new face attribute and use it to modify the defface of a built-in face, this problem will pop up. > Another option that had been voiced is to split the value into two > attributes: :extend-foreground and :extend-background. But :extend is not just about colors, it is also about underline, overline, strike-through, and box attributes. In fact, the underline attribute was an even more important one, because extending it looks exceptionally ugly (we even had a few bug reports about that). > But that brings me to a question. I think whether the 'region' face has > :extend-background to nil or not is a personal choice. Would the user > have to fight and convince the author of the theme they are using to > change that attribute? Or will it be easy to apply personal > customization and call it a day? Why would using a theme need anything beyond a simple face customization to modify :extend (or any other attribute)? The author of a theme can do what they think is best, but users can always override that by customizing the face after loading the theme.