From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Wed, 20 Nov 2019 18:34:55 +0200 Message-ID: <83tv6yzets.fsf@gnu.org> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> <838sob1acp.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="120921"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 20 17:36:58 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXSyO-000V7X-P5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 17:36:56 +0100 Original-Received: from localhost ([::1]:60412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXSyI-0002r1-As for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 11:36:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46350) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXSxX-0001hF-55 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 11:36:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXSxV-0006wt-W9 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 11:36:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41978) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXSxV-0006wp-SF for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 11:36:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXSxV-0003HZ-Ni for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 11:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2019 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157426770312512 (code B ref 38044); Wed, 20 Nov 2019 16:36:01 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 16:35:03 +0000 Original-Received: from localhost ([127.0.0.1]:50795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXSwY-0003Fk-S6 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 11:35:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXSwW-0003FD-Jp for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 11:35:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXSwQ-0006bP-Sx; Wed, 20 Nov 2019 11:34:54 -0500 Original-Received: from [176.228.60.248] (port=3110 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXSwJ-0007Oa-Lt; Wed, 20 Nov 2019 11:34:54 -0500 In-reply-to: (message from Dmitry Gutov on Wed, 20 Nov 2019 14:19:47 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172061 Archived-At: > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Wed, 20 Nov 2019 14:19:47 +0200 > > > I was talking about the VC level, not the vc-git level. vc-git could > > have a show command, but the user of VC would still invoke a variant > > of vc-diff. > > How would that even work? vc-diff will always delegate to vc-git-diff. It will work if we program either vc-diff or vc-git-diff to call "git show" under some specific circumstances. > >> IMO the log message is more important because it describes and justifies > >> what happened. Showing the diff is good as well. > > > > That's not relevant to the issue at hand. Like it or not, VCSes other > > than Git describe a revision by the diffs alone. > > It's 100% relevant, and the fact that certain older VCSes can't do this > should have no bearing on whether we implement a satisfactory UI in VC > or not. That's the whole purpose of VC: make interacting with different > VS systems easier. Easier, yes. But also present the results in a familiar enough form. If users are accustomed to seeing a revision described by diffs, then this is what they should by default see in VC, IMO. > >> Maybe the other VCSes don't have a simple command to do the same, but > >> they can either be called twice, or use special formatting. For > >> instance, Hg can use this command: > >> > >> hg log -r -p > > > > IMO, this is over-engineering. If the VCS developers don't see the > > need to have a commands which shows meta-data together with the diffs, > > we should not force that on that VCS. > > They added the '-p' flag. So apparently they did see the need. Then maybe the hg back-end should indeed call "log -r -p", if that's what hg users are used to (I don't use hg). What I mean is that we should show a revision like users are accustomed to see it with the particular back-end; jumping through hoops to produce Git-like display where users don't really expect it is IMO over-engineering. And I'm also saying that conceptually a revision's description is a kind of "diff" operation, so it should preferably be a sub-command of "C-x v =".