From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Mon, 02 Dec 2019 17:58:16 +0200 Message-ID: <83tv6ilnxj.fsf@gnu.org> References: <87ftj5at1q.fsf@gnus.org> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> <875zizafo1.fsf@rub.de> <835zizmmdq.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193515"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 02 17:04:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iboBE-000oCq-LC for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 17:04:08 +0100 Original-Received: from localhost ([::1]:37898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iboBD-0007Nq-DF for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 11:04:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51819) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibo6K-00043o-BP for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 10:59:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibo6I-0008HG-AG for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 10:59:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibo6H-0008Gx-Sw for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 10:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ibo6H-0008Ty-S5 for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 10:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2019 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157530231932570 (code B ref 38044); Mon, 02 Dec 2019 15:59:01 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 2 Dec 2019 15:58:39 +0000 Original-Received: from localhost ([127.0.0.1]:38805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibo5u-0008TF-KA for submit@debbugs.gnu.org; Mon, 02 Dec 2019 10:58:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibo5t-0008T2-0Y for 38044@debbugs.gnu.org; Mon, 02 Dec 2019 10:58:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ibo5n-000842-9h; Mon, 02 Dec 2019 10:58:31 -0500 Original-Received: from [176.228.60.248] (port=2957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ibo5l-0008K0-Jl; Mon, 02 Dec 2019 10:58:30 -0500 In-reply-to: (message from Dmitry Gutov on Mon, 2 Dec 2019 12:39:47 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172770 Archived-At: > Cc: stephen.berman@gmx.net, larsi@gnus.org, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Mon, 2 Dec 2019 12:39:47 +0200 > > > What do you think about replacing the call to thing-at-point with > > number-at-point, where we look at the revision ID? > > Probably not: > > - Git revisions are SHA hashes, not numbers. Hg also has commit hashes, > though they are less visible. They are both hex numbers. But I failed to notice that number-at-point needs the 0x prefix to detect hex numbers, sorry. (We could have a new function that accepted hex numbers without 0x.) > - I'm pretty sure this command will be just as often used with symbolic > refs such as branch names. So I'd rather use (thing-at-point 'symbol t) > instead. Or a dedicated "thing" that does not depend on the buffer's > syntax (and always includes slashes, hyphens and underscores in addition > to alphanumerics). We are talking about heuristic guesswork to suggest a reasonable default, not about what forms are accepted. I thought that suggesting only numbers, either decimal or hex, as such a guess should be enough, as I almost never see any other revision IDs in practice. (I do use other types of refs with Git, like reflog and stash refs, but those are local and are extremely unlikely to appear in a discussion.) But if you don't feel that's a good idea, it's fine with me. It just strike me as a mild misfeature that we offer completely unrelated words as "revision IDs".