From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38457: 27.0.50; dabbrev-expand regression due to message change Date: Mon, 09 Dec 2019 05:36:50 +0200 Message-ID: <83tv6acgq5.fsf@gnu.org> References: <8736e3vve8.fsf@gmx.net> <8736e2coyv.fsf@mail.linkov.net> <83y2vujd0y.fsf@gnu.org> <87blspm0sm.fsf@mail.linkov.net> <837e3ckbem.fsf@gnu.org> <871rtjn0kt.fsf@mail.linkov.net> <83lfrrigj8.fsf@gnu.org> <87eexiqps5.fsf@mail.linkov.net> <83lfrphp94.fsf@gnu.org> <87wob7g2jk.fsf@mail.linkov.net> <83k177ebs0.fsf@gnu.org> <87muc27prn.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="269523"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38457@debbugs.gnu.org, stephen.berman@gmx.net To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 09 04:38:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ie9sF-00180m-7I for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Dec 2019 04:38:15 +0100 Original-Received: from localhost ([::1]:35588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ie9sD-0008Ni-CH for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Dec 2019 22:38:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49403) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ie9s3-0008NT-Bd for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2019 22:38:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ie9s2-0002De-A5 for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2019 22:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46503) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ie9s2-0002DL-7E for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2019 22:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ie9s2-0004Qy-2s for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2019 22:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Dec 2019 03:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38457 X-GNU-PR-Package: emacs Original-Received: via spool by 38457-submit@debbugs.gnu.org id=B38457.157586263716994 (code B ref 38457); Mon, 09 Dec 2019 03:38:02 +0000 Original-Received: (at 38457) by debbugs.gnu.org; 9 Dec 2019 03:37:17 +0000 Original-Received: from localhost ([127.0.0.1]:52476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ie9rJ-0004Q2-4O for submit@debbugs.gnu.org; Sun, 08 Dec 2019 22:37:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ie9rG-0004Po-P4 for 38457@debbugs.gnu.org; Sun, 08 Dec 2019 22:37:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ie9rA-0001sN-Vh; Sun, 08 Dec 2019 22:37:09 -0500 Original-Received: from [176.228.60.248] (port=2164 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ie9r8-00071R-Qb; Sun, 08 Dec 2019 22:37:08 -0500 In-reply-to: <87muc27prn.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 08 Dec 2019 23:50:28 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173082 Archived-At: > From: Juri Linkov > Cc: bug-gnu-emacs@gnu.org, 38457@debbugs.gnu.org, stephen.berman@gmx.net > Date: Sun, 08 Dec 2019 23:50:28 +0200 > > > The original problem which the change in 'message' tried to solve, the one > > reported in bugs #17272 and #19064, was about calling 'message' when > > y-or-n-p is prompting the user. So how about if we modify the conditions > > under which 'message' calls 'minibuffer-message' such that this happens > > only when y-or-n-p is in progress? E.g., y-or-n-p could bind some variable > > that 'message' would check. > > No, it was not only about y-or-n-p, but about any command that uses the minibuffer. As it turns out, not any command, because "M-x" and "C-x C-f" also use the minibuffer. And the original bug reports definitely were about y-or-n-p. > > Maybe yes-or-no-p should do the same. > > > > This will allow us to fix the original bugs without such wide implications as we have now. > > > > And while at that, I don't think we need the new function message-on-echo-area; the additional logic could be added to 'message's original code. > > > > WDYT? > > Inventing hacks and workarounds is too risky and error-prone > than installing the proper and safest solution. I don't see how this is a "hack" when it uses the same technique as your changes in 'message': checking a variable that is bound by other functions. The advantage of my proposal is that it makes the new functionality opt-in, so that any commands which need this could have it by simply binding a variable, and would otherwise maintain its old behavior, which was there for eons. This issue is basically the only one that's left before we can cut the release branch. Please help me resolve this issue so that we could start the pretest of Emacs 27. Thanks.