From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39597: 27.0.60: M-x occur adds fontification to fundamental-mode Date: Fri, 21 Feb 2020 09:40:34 +0200 Message-ID: <83tv3kjslp.fsf@gnu.org> References: <87imk960qb.fsf@gmail.com> <8736b8eosv.fsf@mail.linkov.net> <874kvna4uv.fsf@mail.linkov.net> <83zhddjomi.fsf@gnu.org> <871rqpt6qm.fsf@gmail.com> <83wo8hjajp.fsf@gnu.org> <87sgj4sxlu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="48558"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39597@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 21 08:41:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j52vv-000CXt-Ey for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 08:41:11 +0100 Original-Received: from localhost ([::1]:53216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j52vu-0008Lp-7p for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 02:41:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51242) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j52vm-0008Lf-NR for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 02:41:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j52vl-0004BD-Q6 for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 02:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j52vl-0004AV-MR for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 02:41:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j52vl-0001yI-JG for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 02:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 07:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39597 X-GNU-PR-Package: emacs Original-Received: via spool by 39597-submit@debbugs.gnu.org id=B39597.15822708527550 (code B ref 39597); Fri, 21 Feb 2020 07:41:01 +0000 Original-Received: (at 39597) by debbugs.gnu.org; 21 Feb 2020 07:40:52 +0000 Original-Received: from localhost ([127.0.0.1]:46288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j52vc-0001xi-B3 for submit@debbugs.gnu.org; Fri, 21 Feb 2020 02:40:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j52vb-0001xW-80 for 39597@debbugs.gnu.org; Fri, 21 Feb 2020 02:40:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j52vW-00038l-2e; Fri, 21 Feb 2020 02:40:46 -0500 Original-Received: from [176.228.60.248] (port=3919 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j52vV-0008UM-Gg; Fri, 21 Feb 2020 02:40:45 -0500 In-reply-to: <87sgj4sxlu.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Thu, 20 Feb 2020 23:27:41 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176344 Archived-At: > From: Kévin Le Gouguec > Date: Thu, 20 Feb 2020 23:27:41 +0100 > > >> I think commit fb16313025 (2018-12-18T23:10:09Z!juri linkov.net) had an > >> unintended side-effect on fundamental-mode. From emacs -Q: > > > > This commit contains this change: > > > > diff --git a/lisp/replace.el b/lisp/replace.el > > index dcae12e9b7..b8f231eb55 100644 > > --- a/lisp/replace.el > > +++ b/lisp/replace.el > > @@ -1907,10 +1907,8 @@ occur-engine > > global-matches))) > > > > (defun occur-engine-line (beg end &optional keep-props) > > - (if (and keep-props (if (boundp 'jit-lock-mode) jit-lock-mode) > > - (text-property-not-all beg end 'fontified t)) > > - (if (fboundp 'jit-lock-fontify-now) > > - (jit-lock-fontify-now beg end))) > > + (if (and keep-props font-lock-mode) > > + (font-lock-ensure beg end)) > > (if (and keep-props (not (eq occur-excluded-properties t))) > > (let ((str (buffer-substring beg end))) > > (remove-list-of-text-properties Thanks. The fix installed on master is in a much more general place, and will affect much more than just occur-engine. I'm okay with a bug-fix change on the release branch which is local to this place in replace.el, but I don't want to risk breaking unrelated code by changing font-lock.el. Another alternative is to revert the offending changes in fb16313025 on the release branch. Since it is an enhancement, perhaps we could live without it in Emacs 27.