unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: cpitclaudel@gmail.com, 40687-done@debbugs.gnu.org
Subject: bug#40687: Missing right border on composed text used in 'display property
Date: Fri, 24 Apr 2020 15:26:58 +0300	[thread overview]
Message-ID: <83tv199ii5.fsf@gnu.org> (raw)
In-Reply-To: <m2tv19xewe.fsf@gmail.com> (message from Robert Pluim on Fri, 24 Apr 2020 14:10:57 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Clément Pit-Claudel <cpitclaudel@gmail.com>,
>   40687@debbugs.gnu.org
> Date: Fri, 24 Apr 2020 14:10:57 +0200
> 
> >>>>> On Thu, 23 Apr 2020 18:48:09 +0300, Eli Zaretskii <eliz@gnu.org> said:
> 
>     Eli> Thanks, should be fixed now.
> 
>     Eli> FTR, a recipe to test more fully display of composed text with a :box
>     Eli> face is below.  I found quite a few problems with this, especially
>     Eli> when the text in the boxed face ends with a composed character.  They
>     Eli> should be fixed now on the master branch.  I tested this fully only on
>     Eli> MS-Windows; could someone please use the recipe below to verify the
>     Eli> display looks correctly also on X and on NS?  Note that what appears
>     Eli> below to be LATIN SMALL LETTER A WITH ACUTE is not a single character,
>     Eli> but 2 characters that are composed into a single glyph.
> 
> It all looks correct on NS as well (once I switched to a font that had both
> an 'a' and a COMBINING ACUTE ACCENT glyph, Menlo in this case)

Great, so I'm closing this bug.  Thanks to all who supported the
testing of the fix.

P.S. FTR: the fix is on the master branch, so it will be in Emacs
28.1.





  reply	other threads:[~2020-04-24 12:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 19:44 bug#40687: Missing right border on composed text used in 'display property Clément Pit-Claudel
2020-04-17 20:33 ` Stephen Berman
2020-04-17 21:11   ` Clément Pit-Claudel
2020-04-23 15:49   ` Eli Zaretskii
2020-04-23 15:48 ` Eli Zaretskii
2020-04-23 20:07   ` Stephen Berman
2020-04-23 20:25     ` Clément Pit-Claudel
2020-04-24  6:43       ` Eli Zaretskii
2020-04-24  6:33     ` Eli Zaretskii
2020-04-24 12:10   ` Robert Pluim
2020-04-24 12:26     ` Eli Zaretskii [this message]
2020-04-24 14:01       ` Clément Pit-Claudel
2020-04-24 14:06         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tv199ii5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=40687-done@debbugs.gnu.org \
    --cc=cpitclaudel@gmail.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).