From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41520: 28.0.50; Crash in character.h due to assertion error Date: Mon, 25 May 2020 19:09:25 +0300 Message-ID: <83tv04uhca.fsf@gnu.org> References: <83imgkw11q.fsf@gnu.org> <837dx0vysk.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="17423"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41520@debbugs.gnu.org, stefan@marxist.se To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 25 18:10:26 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdFgH-0004QT-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 May 2020 18:10:25 +0200 Original-Received: from localhost ([::1]:44480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdFgG-00068H-Hx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 May 2020 12:10:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdFfu-00066u-T5 for bug-gnu-emacs@gnu.org; Mon, 25 May 2020 12:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdFfu-0003CZ-J5 for bug-gnu-emacs@gnu.org; Mon, 25 May 2020 12:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdFfu-0008Q3-Dz for bug-gnu-emacs@gnu.org; Mon, 25 May 2020 12:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 May 2020 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41520 X-GNU-PR-Package: emacs Original-Received: via spool by 41520-submit@debbugs.gnu.org id=B41520.159042296132307 (code B ref 41520); Mon, 25 May 2020 16:10:02 +0000 Original-Received: (at 41520) by debbugs.gnu.org; 25 May 2020 16:09:21 +0000 Original-Received: from localhost ([127.0.0.1]:42245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdFfF-0008P1-Bg for submit@debbugs.gnu.org; Mon, 25 May 2020 12:09:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdFfD-0008Oo-OB for 41520@debbugs.gnu.org; Mon, 25 May 2020 12:09:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51712) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdFf8-00038f-0h; Mon, 25 May 2020 12:09:14 -0400 Original-Received: from [176.228.60.248] (port=3880 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jdFf7-0004jV-Df; Mon, 25 May 2020 12:09:13 -0400 In-Reply-To: (message from Pip Cet on Mon, 25 May 2020 15:16:09 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180987 Archived-At: > From: Pip Cet > Date: Mon, 25 May 2020 15:16:09 +0000 > Cc: stefan@marxist.se, 41520@debbugs.gnu.org > > > But wouldn't it be strange to see a macro that accepts a struct, but > > only uses one member of that struct? > > I don't think so. CHARPOS and BYTEPOS already exist, and that's > precisely what they do. > > What is a little strange is that the ancient convention of not > returning struct types is still followed in much of Emacs. It's more expensive. That's what I meant when I said "strange": why would we fill 2 fields of a struct, but use only one? > > I mean we already have assertions: that's what eassume does in a debug > > build. > > Yes, but we could do with some stricter checking, I think. It cannot catch the cases where we put a character position into the byte position slot. That's the general problem with using simple scalars.