From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Mon, 01 Jun 2020 19:32:39 +0300 Message-ID: <83tuzueogo.fsf@gnu.org> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <87r1v2aat3.fsf@tromey.com> <9902865C-01B4-4E50-A433-DBC8B8311234@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="102709"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tom@tromey.com, simon@polaris64.net, 41544@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 01 18:33:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jfnN7-000QbG-VQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Jun 2020 18:33:09 +0200 Original-Received: from localhost ([::1]:35140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfnN7-0005IC-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Jun 2020 12:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfnN0-0005Hy-Jz for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 12:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfnN0-0006Df-Ah for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 12:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfnN0-00017o-7E for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 12:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Jun 2020 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.15910291684303 (code B ref 41544); Mon, 01 Jun 2020 16:33:02 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 1 Jun 2020 16:32:48 +0000 Original-Received: from localhost ([127.0.0.1]:36848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfnMl-00017L-S4 for submit@debbugs.gnu.org; Mon, 01 Jun 2020 12:32:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfnMk-000178-Dy for 41544@debbugs.gnu.org; Mon, 01 Jun 2020 12:32:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52109) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfnMd-0006C0-Ri; Mon, 01 Jun 2020 12:32:40 -0400 Original-Received: from [176.228.60.248] (port=4654 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jfnMc-00066W-Qn; Mon, 01 Jun 2020 12:32:39 -0400 In-Reply-To: <9902865C-01B4-4E50-A433-DBC8B8311234@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sun, 31 May 2020 22:46:07 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181349 Archived-At: > From: Mattias Engdegård > Date: Sun, 31 May 2020 22:46:07 +0200 > Cc: Simon Pugnet , 41544@debbugs.gnu.org, > Eli Zaretskii > > Proposed patch attached. I found css-mode no worse than before (a tad better, if anything). Perhaps we need to decompress to linear components after all, but at least now there is a single place to do it. > > (Should list-colors-display use color-dark-p for the text in its left column, by the way? Or is there a point in not doing so?) Please remind me why do we want to make such deep and wide changes in our color system? Is that just because we have a minor bug in color-distance? Wouldn't it be better to just fix that one bug? I'm worried because the way our automatic color mapping on color-challenged TTYs works took some time to get right, and it worked well for years. If we want to risk rocking that particular boat som profoundly, we had better had a very good reason, preferably several good reasons. Thanks.