From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42222: 26.3; `called-interactively-p' doc is incorrect and misleading Date: Sat, 11 Jul 2020 13:01:46 +0300 Message-ID: <83tuyenzed.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1083"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42222@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 11 12:03:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1juCLe-0000BT-FA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Jul 2020 12:03:10 +0200 Original-Received: from localhost ([::1]:60472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juCLd-0006Uk-86 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Jul 2020 06:03:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juCLW-0006UY-0V for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 06:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1juCLV-0007LX-N9 for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 06:03:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1juCLV-00010M-Jd for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 06:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jul 2020 10:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42222 X-GNU-PR-Package: emacs Original-Received: via spool by 42222-submit@debbugs.gnu.org id=B42222.15944617303799 (code B ref 42222); Sat, 11 Jul 2020 10:03:01 +0000 Original-Received: (at 42222) by debbugs.gnu.org; 11 Jul 2020 10:02:10 +0000 Original-Received: from localhost ([127.0.0.1]:43855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juCKf-0000z8-Og for submit@debbugs.gnu.org; Sat, 11 Jul 2020 06:02:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juCKd-0000yq-Sa; Sat, 11 Jul 2020 06:02:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53926) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juCKY-0007Eq-DO; Sat, 11 Jul 2020 06:02:02 -0400 Original-Received: from [176.228.60.248] (port=4755 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1juCKT-0005EF-C6; Sat, 11 Jul 2020 06:02:00 -0400 In-Reply-To: (message from Drew Adams on Sun, 5 Jul 2020 16:33:33 -0700 (PDT)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182909 Archived-At: tags 42222 notabug thanks > Date: Sun, 5 Jul 2020 16:33:33 -0700 (PDT) > From: Drew Adams > > 1. Wrong signature: > > called-interactively-p is a compiled Lisp function in 'subr.el'. > > (called-interactively-p KIND) This is intentional, due to the 'advertised-calling-convention' form. > 2. Nothing is said about the case where KIND is absent or nil. See above. > Nothing is said about the behavior where KIND is anything other than > `interactive' or `any'. We don't have to. It means that any other value invokes undefined behavior. > 4. On the other hand, if the intention really is to _require_ KIND, so > that what the Elisp manual says is true: "KIND should be either the > symbol 'interactive' or the symbol 'any'", then the function should > raise an error when KIND is missing (and the "should" should then > be changed to "must"). Signaling an error is backward-incompatible, so it is not always TRT. > Probably introduced at or before Emacs version 22.1. > > Such meta-information should not be placed up front like that. We clearly disagree. There's no bug here. Thanks.