From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: sebastian_rose@gmx.de, stephen.berman@gmx.net, 5050@debbugs.gnu.org
Subject: bug#5050: 23.1; efiff: Displaying bytes instead of characters in messages
Date: Thu, 20 Aug 2020 22:50:16 +0300 [thread overview]
Message-ID: <83tuwxayh3.fsf@gnu.org> (raw)
In-Reply-To: <87blj5ksso.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 20 Aug 2020 21:42:47 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 20 Aug 2020 21:42:47 +0200
> Cc: Sebastian Rose <sebastian_rose@gmx.de>, 5050@debbugs.gnu.org
>
> (defun ediff-exec-process (program buffer synch options &rest files)
>
> [...]
>
> ;; If this is a buffer job, we are diffing temporary files
> ;; produced by Emacs with ediff-coding-system-for-write, so
> ;; use the same encoding to read the results.
> (coding-system-for-read
> (if (string-match "buffer" (symbol-name ediff-job-name))
> ediff-coding-system-for-write
> ediff-coding-system-for-read))
> args)
>
> This is the problem: ediff-coding-system-for-read is raw-text, which
> gives us the binary data in the buffer instead of characters.
How else can you compare files which could have different encodings?
And anyway, Stephen just answered my question, and the diffs are
displayed correctly with non-ASCII characters, not as raw bytes. So
there's more here than meets the eye.
next prev parent reply other threads:[~2020-08-20 19:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 20:13 bug#5050: 23.1; efiff: Displaying bytes instead of characters in messages Sebastian Rose
2009-11-27 16:01 ` Kevin Rodgers
2020-08-20 18:38 ` Lars Ingebrigtsen
2020-08-20 18:53 ` Stephen Berman
2020-08-20 19:21 ` Eli Zaretskii
2020-08-20 19:35 ` Stephen Berman
2020-08-20 19:42 ` Eli Zaretskii
2020-08-20 19:28 ` Lars Ingebrigtsen
2020-08-20 19:42 ` Lars Ingebrigtsen
2020-08-20 19:50 ` Eli Zaretskii [this message]
2020-08-20 20:01 ` Lars Ingebrigtsen
2020-08-20 20:12 ` Eli Zaretskii
2020-08-20 20:18 ` Lars Ingebrigtsen
2020-08-20 20:24 ` Lars Ingebrigtsen
2020-08-20 20:36 ` Stephen Berman
2020-08-21 11:21 ` Lars Ingebrigtsen
2020-08-20 20:17 ` Lars Ingebrigtsen
2020-08-20 19:51 ` Stephen Berman
2020-08-20 20:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tuwxayh3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=5050@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=sebastian_rose@gmx.de \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).