From: Eli Zaretskii <eliz@gnu.org>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: schwab@linux-m68k.org, 43375@debbugs.gnu.org
Subject: bug#43375: 26.1: file-directory-p returns t for empty string
Date: Sun, 13 Sep 2020 18:01:51 +0300 [thread overview]
Message-ID: <83tuw1bu00.fsf@gnu.org> (raw)
In-Reply-To: <20200913143943.6u5zt4wyxney5wlh@E15-2016.optimum.net> (message from Boruch Baum on Sun, 13 Sep 2020 10:39:43 -0400)
> Date: Sun, 13 Sep 2020 10:39:43 -0400
> From: Boruch Baum <boruch_baum@gmx.com>
> Cc: 43375@debbugs.gnu.org
>
> > > (file-directory-p "")
> >
> > This is not a bug, as Emacs always works with expanded and canonicalized
> > file names (the result of applying expand-file-name).
>
> Then the docstring could be clearer and say "Return t if the expansion
> of FILENAME names an existing directory"
That's not a useful doc string, because "expansion of FILENAME" is not
well defined, and is not easy to describe.
I'm okay with making the doc string more clear, but let's please think
about a more useful amendment. A doc string should help the user
understand what will/did happen, it shouldn't present puzzles.
next prev parent reply other threads:[~2020-09-13 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 12:47 bug#43375: 26.1: file-directory-p returns t for empty string Boruch Baum
2020-09-13 13:06 ` Andreas Schwab
2020-09-13 13:34 ` Lars Ingebrigtsen
2020-09-13 14:40 ` Boruch Baum
2020-09-13 14:39 ` Boruch Baum
2020-09-13 15:01 ` Eli Zaretskii [this message]
2020-09-13 16:29 ` Boruch Baum
2020-09-13 16:47 ` Eli Zaretskii
2020-09-13 15:56 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tuw1bu00.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=43375@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).