From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44338: 27.1; EWW can't download and view pdf Date: Wed, 04 Nov 2020 17:07:42 +0200 Message-ID: <83tuu5b1oh.fsf@gnu.org> References: <878sbmo6i0.fsf@tcd.ie> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24071"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 44338@debbugs.gnu.org To: Nicholas Harrison Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 04 16:23:05 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaKcr-00069E-1X for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Nov 2020 16:23:05 +0100 Original-Received: from localhost ([::1]:44954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaKcp-0001rH-Vu for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Nov 2020 10:23:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaKOI-0003mY-Tf for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 10:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaKOI-0006ic-K4 for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 10:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kaKOI-0000Xo-Ck for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 10:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Nov 2020 15:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44338-submit@debbugs.gnu.org id=B44338.16045024782082 (code B ref 44338); Wed, 04 Nov 2020 15:08:02 +0000 Original-Received: (at 44338) by debbugs.gnu.org; 4 Nov 2020 15:07:58 +0000 Original-Received: from localhost ([127.0.0.1]:50243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaKOE-0000XW-5e for submit@debbugs.gnu.org; Wed, 04 Nov 2020 10:07:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaKOC-0000XK-C9 for 44338@debbugs.gnu.org; Wed, 04 Nov 2020 10:07:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41092) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaKO5-0006fp-H7; Wed, 04 Nov 2020 10:07:50 -0500 Original-Received: from [176.228.60.248] (port=2100 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kaKO4-0006IW-Ow; Wed, 04 Nov 2020 10:07:49 -0500 In-Reply-To: (message from Nicholas Harrison on Tue, 3 Nov 2020 16:52:40 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192671 Archived-At: > From: Nicholas Harrison > Date: Tue, 3 Nov 2020 16:52:40 -0700 > Cc: 44338@debbugs.gnu.org > > This can be (partially) corrected by running the following code before the steps 2 and 3: > (add-to-list 'mailcap-user-mime-data > '((type . "application/pdf") > (viewer . doc-view-mode))) > > This chooses a view mode for the pdf but that brings the second problem. This selects the default encoding > of raw-text and the conversion fails: You say it selects raw-text, but the screenshot you sent clearly shows that Emacs was trying to use iso-latin-1-dos. In which case the failure is easily understandable, but I don't immediately see where did that value come from (it's most probably the default value of buffer-file-coding-system for you, but since eww-display-pdf binds coding-system-for-write, the question is why that value isn't being used). Could you perhaps produce a backtrace from that situation? For example, like this: M-: (debug-on-entry 'select-safe-coding-system) RET and then repeat the recipe. In any case, this isn't right: (defun eww-display-pdf () (let ((data (buffer-substring (point) (point-max)))) (pop-to-buffer-same-window (get-buffer-create "*eww pdf*")) (let ((coding-system-for-write 'raw-text) <<<<<<<<<<<<<<<<<<<<<< (inhibit-read-only t)) (erase-buffer) (insert data) (mailcap-view-mime "application/pdf"))) (goto-char (point-min))) We should use 'raw-text-unix here, since the buffer contents is a stream of raw bytes.